Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-cli): check total memory only #4503

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Sep 21, 2021

Summary

Available memory is unreliable indicator. Only check total memory when daemonizing the process.

Checklist

  • Tests
  • Ready to be merged

@sebastijankuzner sebastijankuzner changed the title fix(core-api): check total memory only fix(core-cli): check total memory only Sep 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2021

Codecov Report

Merging #4503 (c0bc34e) into develop (26d49d8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4503      +/-   ##
===========================================
- Coverage    95.57%   95.56%   -0.01%     
===========================================
  Files          687      687              
  Lines        17496    17494       -2     
  Branches      2142     2141       -1     
===========================================
- Hits         16722    16719       -3     
  Misses         568      568              
- Partials       206      207       +1     
Flag Coverage Δ
functional 6.01% <0.00%> (+<0.01%) ⬆️
integration 10.00% <0.00%> (+<0.01%) ⬆️
unit 94.10% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-cli/src/actions/daemonize-process.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/network-monitor.ts 97.76% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d49d8...c0bc34e. Read the comment docs.

@sebastijankuzner sebastijankuzner merged commit 3142b40 into develop Sep 21, 2021
@sebastijankuzner sebastijankuzner deleted the fix/core-cli/check-potato-total-memory-only branch September 21, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants