-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send new height with postBlock response #4482
Send new height with postBlock response #4482
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4482 +/- ##
===========================================
- Coverage 95.87% 95.86% -0.01%
===========================================
Files 744 744
Lines 18494 18493 -1
Branches 2250 2248 -2
===========================================
- Hits 17731 17729 -2
- Misses 561 562 +1
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi, Will the reply schema also need to be updated so it accepts objects of type core/packages/core-p2p/src/schemas.ts Lines 187 to 189 in 9cdf872
|
Summary
Send new height with
postBlock
response. It's used to update/api/peers
endpoint. Fixes #4448Checklist