Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): disable perMessageDeflate on WS #4441

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Jul 8, 2021

Summary

Disable perMessageDefalate option on client and listener. Setting perMessageDefalate to false disables websocket compression.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@sebastijankuzner sebastijankuzner changed the title chore(core-p2p): disable perMessageDeflate on WS fix(core-p2p): disable perMessageDeflate on WS Jul 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #4441 (e1715de) into develop (13d0709) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4441      +/-   ##
===========================================
- Coverage    95.86%   95.86%   -0.01%     
===========================================
  Files          738      738              
  Lines        18361    18360       -1     
  Branches      2243     2242       -1     
===========================================
- Hits         17601    17600       -1     
  Misses         557      557              
  Partials       203      203              
Flag Coverage Δ
functional 5.74% <0.00%> (+<0.01%) ⬆️
integration 9.53% <0.00%> (+<0.01%) ⬆️
unit 94.46% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/hapi-nes/client.ts 94.93% <100.00%> (-0.03%) ⬇️
packages/core-p2p/src/hapi-nes/listener.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d0709...e1715de. Read the comment docs.

@sebastijankuzner sebastijankuzner merged commit 7a6d198 into develop Jul 8, 2021
@sebastijankuzner sebastijankuzner deleted the chore/core-p2p/ws-options branch July 8, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants