Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): reset max payload after ping #4440

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jul 7, 2021

Summary

Re-opened #4434 by @alessiodf because it sill reduces probability of race when peers are communicating with each other.

Checklist

  • Tests
  • Ready to be merged

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@6dbf484). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #4440   +/-   ##
=========================================
  Coverage           ?   9.53%           
=========================================
  Files              ?     738           
  Lines              ?   18360           
  Branches           ?    2242           
=========================================
  Hits               ?    1751           
  Misses             ?   16513           
  Partials           ?      96           
Flag Coverage Δ
integration 9.53% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/hapi-nes/client.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbf484...ee65586. Read the comment docs.

@sebastijankuzner sebastijankuzner merged commit 4dd78dd into develop Jul 9, 2021
@sebastijankuzner sebastijankuzner deleted the fix/core-p2p/reset-max-payload-after-ping branch July 9, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants