Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-state): iterate over active delegates who have ranks #4421

Merged

Conversation

rainydio
Copy link
Contributor

Summary

Iterate over getActiveDelegates() because those have ranks.

Checklist

  • Tests
  • Ready to be merged

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #4421 (b6b5203) into develop (76ecfe3) will decrease coverage by 1.32%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4421      +/-   ##
===========================================
- Coverage    95.88%   94.56%   -1.33%     
===========================================
  Files          738      738              
  Lines        18360    18361       +1     
  Branches      2242     2242              
===========================================
- Hits         17605    17363     -242     
- Misses         554      799     +245     
+ Partials       201      199       -2     
Flag Coverage Δ
functional ?
integration 9.53% <0.00%> (-0.01%) ⬇️
unit 94.48% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/core-state/src/dpos/dpos-previous-round.ts 92.85% <0.00%> (-7.15%) ⬇️
packages/core-state/src/round-state.ts 100.00% <100.00%> (ø)
...rc/migrations/20190307000000-drop-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305200000-create-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305300000-create-blocks-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../migrations/20180305100000-create-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../migrations/20201013000000-create-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...igrations/20190626000000-enforce-chained-blocks.ts 0.00% <0.00%> (-100.00%) ⬇️
...grations/20201103000000-set-autovacuum-settings.ts 0.00% <0.00%> (-100.00%) ⬇️
...rations/20191003000000-migrate-vendor-field-hex.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ecfe3...b6b5203. Read the comment docs.

@faustbrian faustbrian merged commit d634a92 into develop Jun 17, 2021
@faustbrian faustbrian deleted the fix/core-state/revert-round-get-active-delegates branch June 17, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants