Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-blockchain): remove updateNetworkStatus on Blockchain #4402

Merged

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented May 31, 2021

Summary

Remove unused updateNetworkStatus method on Blockchain.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@sebastijankuzner sebastijankuzner marked this pull request as draft May 31, 2021 09:36
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #4402 (41fa76d) into develop (14d162d) will increase coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4402      +/-   ##
===========================================
+ Coverage    94.54%   95.86%   +1.32%     
===========================================
  Files          738      738              
  Lines        18366    18365       -1     
  Branches      2243     2243              
===========================================
+ Hits         17364    17606     +242     
+ Misses         801      557     -244     
- Partials       201      202       +1     
Flag Coverage Δ
functional 5.73% <ø> (?)
integration 9.53% <ø> (+<0.01%) ⬆️
unit 94.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-blockchain/src/blockchain.ts 100.00% <ø> (ø)
packages/core-p2p/src/network-monitor.ts 98.14% <0.00%> (+0.37%) ⬆️
packages/core-database/src/utils/transform.ts 100.00% <0.00%> (+25.00%) ⬆️
...core-database/src/repositories/round-repository.ts 88.88% <0.00%> (+55.55%) ⬆️
...atabase/src/repositories/transaction-repository.ts 84.09% <0.00%> (+65.90%) ⬆️
...core-database/src/repositories/block-repository.ts 89.18% <0.00%> (+81.08%) ⬆️
...e-database/src/repositories/abstract-repository.ts 94.52% <0.00%> (+89.04%) ⬆️
...rc/migrations/20190307000000-drop-wallets-table.ts 100.00% <0.00%> (+100.00%) ⬆️
...c/migrations/20180305200000-create-rounds-table.ts 100.00% <0.00%> (+100.00%) ⬆️
...c/migrations/20180305300000-create-blocks-table.ts 100.00% <0.00%> (+100.00%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d162d...41fa76d. Read the comment docs.

@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale label Jul 1, 2021
@sebastijankuzner sebastijankuzner marked this pull request as ready for review July 9, 2021 13:11
@stale stale bot removed the Status: Stale label Jul 9, 2021
@sebastijankuzner sebastijankuzner merged commit c1af74d into develop Jul 12, 2021
@sebastijankuzner sebastijankuzner deleted the chore/core-blockchain/remove-update-network-status branch July 12, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants