Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transaction-pool): prioritized removeForgedTransaction #4389

Merged

Conversation

rainydio
Copy link
Contributor

Summary

removeForgedTransaction no longer awaits potentially long addTransaction queue.

Checklist

  • Tests
  • Ready to be merged

@rainydio rainydio marked this pull request as ready for review May 17, 2021 08:36
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

Merging #4389 (4c3f639) into develop (56111ed) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #4389   +/-   ##
=======================================
  Coverage     9.54%   9.54%           
=======================================
  Files          738     738           
  Lines        18340   18339    -1     
  Branches      2236    2236           
=======================================
  Hits          1751    1751           
+ Misses       16493   16492    -1     
  Partials        96      96           
Flag Coverage Δ
integration 9.54% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/core-transaction-pool/src/sender-mempool.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56111ed...4c3f639. Read the comment docs.

@air1one air1one merged commit ee8c5e3 into develop May 17, 2021
@air1one air1one deleted the fix/core-transaction-pool/slow-remove-forged-transaction branch May 17, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants