Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): inject objects with Inversify #4341

Merged
merged 24 commits into from
Mar 8, 2021

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Feb 27, 2021

Summary

Inject objects via Inversify.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov-io
Copy link

codecov-io commented Feb 27, 2021

Codecov Report

Merging #4341 (bdd9ff9) into develop (7c27eda) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4341   +/-   ##
========================================
  Coverage    95.81%   95.81%           
========================================
  Files          735      735           
  Lines        18220    18216    -4     
  Branches      2232     2230    -2     
========================================
- Hits         17457    17454    -3     
  Misses         561      561           
+ Partials       202      201    -1     
Flag Coverage Δ
functional 5.78% <0.00%> (+<0.01%) ⬆️
integration 9.60% <0.00%> (+0.01%) ⬆️
unit 94.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/peer-verifier.ts 99.42% <ø> (+0.58%) ⬆️
packages/core-p2p/src/service-provider.ts 100.00% <ø> (ø)
...kages/core-p2p/src/socket-server/schemas/blocks.ts 100.00% <ø> (ø)
...ackages/core-p2p/src/socket-server/schemas/peer.ts 100.00% <ø> (ø)
packages/core-p2p/src/network-monitor.ts 98.88% <100.00%> (-0.01%) ⬇️
packages/core-p2p/src/peer-communicator.ts 97.27% <100.00%> (+0.01%) ⬆️
packages/core-p2p/src/peer-processor.ts 100.00% <100.00%> (ø)
...s/core-p2p/src/socket-server/controllers/blocks.ts 93.47% <100.00%> (ø)
...core-p2p/src/socket-server/controllers/internal.ts 100.00% <100.00%> (ø)
...ges/core-p2p/src/socket-server/controllers/peer.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c27eda...bdd9ff9. Read the comment docs.

# Conflicts:
#	__tests__/unit/core-p2p/socket-server/controllers/peer.test.ts
@sebastijankuzner sebastijankuzner marked this pull request as ready for review March 1, 2021 12:07
@faustbrian faustbrian merged commit 3b2f5eb into develop Mar 8, 2021
@faustbrian faustbrian deleted the refactor/core-p2p/inject branch March 8, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants