Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): peer rate limiter #4310

Closed
wants to merge 6 commits into from

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Feb 8, 2021

Summary

Refactored rate limiter. Now it has two separate methods for handling incoming and outgoing requests.

Checklist

  • Tests
  • Ready to be merged

@codecov-io
Copy link

codecov-io commented Feb 8, 2021

Codecov Report

Merging #4310 (6a0af7d) into develop (cb75481) will decrease coverage by 86.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #4310       +/-   ##
===========================================
- Coverage    95.91%   9.61%   -86.31%     
===========================================
  Files          735     735               
  Lines        18153   18154        +1     
  Branches      2228    2222        -6     
===========================================
- Hits         17412    1745    -15667     
- Misses         546   16314    +15768     
+ Partials       195      95      -100     
Flag Coverage Δ
functional ?
integration 9.61% <0.00%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-kernel/src/ioc/identifiers.ts 0.00% <ø> (-100.00%) ⬇️
packages/core-p2p/src/peer-communicator.ts 0.00% <0.00%> (-97.27%) ⬇️
packages/core-p2p/src/peer-controller.ts 0.00% <0.00%> (ø)
packages/core-p2p/src/peer-rate-limiter.ts 0.00% <0.00%> (ø)
packages/core-p2p/src/service-provider.ts 0.00% <0.00%> (-100.00%) ⬇️
...s/core-p2p/src/socket-server/plugins/rate-limit.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/cli.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/crypto/src/enums.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/schemas.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 696 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb75481...6a0af7d. Read the comment docs.

@rainydio rainydio closed this Mar 2, 2021
@rainydio rainydio deleted the refactor/core-p2p/peer-rate-limiter branch March 2, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants