Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-state): test every wallet vote balance #4285

Merged

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jan 25, 2021

Summary

Tests are now comparing results of two functions to check vote balances:

  • getExpectedVoteBalances that returns calculated vote balance values.
  • getActualVoteBalances that returns actual delegate.voteBalance values.

Checklist

  • Tests
  • Ready to be merged

@rainydio rainydio marked this pull request as ready for review January 25, 2021 14:01
@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #4285 (793d861) into develop (010592c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4285   +/-   ##
========================================
  Coverage    94.69%   94.69%           
========================================
  Files          729      729           
  Lines        18013    18013           
  Branches      2207     2207           
========================================
  Hits         17058    17058           
  Misses         764      764           
  Partials       191      191           
Flag Coverage Δ
integration 9.68% <ø> (ø)
unit 94.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010592c...793d861. Read the comment docs.

@faustbrian faustbrian merged commit 348f63d into develop Jan 27, 2021
@faustbrian faustbrian deleted the refactor/core-state/test-every-wallet-vote-balance branch January 27, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants