Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-transaction-pool): pool processor to be injected directly #4278

Merged
merged 4 commits into from
Jan 25, 2021

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jan 22, 2021

Summary

Allow pool processor to be injected directly (instead of having to use factory).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #4278 (e3ecfe3) into develop (59b9400) will decrease coverage by 86.34%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #4278       +/-   ##
===========================================
- Coverage    96.04%   9.70%   -86.35%     
===========================================
  Files          728     728               
  Lines        17972   17968        -4     
  Branches      2203    2203               
===========================================
- Hits         17262    1744    -15518     
- Misses         519   16129    +15610     
+ Partials       191      95       -96     
Flag Coverage Δ
functional ?
integration 9.70% <11.11%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-p2p/src/socket-server/controllers/transactions.ts 0.00% <0.00%> (-100.00%) ⬇️
...-framework/src/mocks/transaction-pool-processor.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/core-transaction-pool/src/processor.ts 0.00% <0.00%> (-71.16%) ⬇️
packages/core-api/src/controllers/transactions.ts 81.01% <100.00%> (-18.99%) ⬇️
packages/core/src/cli.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/crypto/src/enums.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/schemas.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/crypto/src/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/commands/top.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 686 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a273cb4...e82a359. Read the comment docs.

@air1one air1one marked this pull request as ready for review January 22, 2021 15:42
@faustbrian faustbrian merged commit 147c4de into develop Jan 25, 2021
@faustbrian faustbrian deleted the refactor/tx-pool-process-inject branch January 25, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants