Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transactions): fix unvote+vote bootstrap #4097

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

rainydio
Copy link
Contributor

Fix unvote+vote bootstrap by making it nearly identical to applyToSender

@ghost ghost added Complexity: Low labels Oct 15, 2020
@rainydio rainydio marked this pull request as ready for review October 15, 2020 17:34
@ghost ghost added needsReview and removed inProgress labels Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #4097 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4097   +/-   ##
========================================
  Coverage    96.66%   96.66%           
========================================
  Files          716      716           
  Lines        17229    17229           
  Branches      2096     2096           
========================================
  Hits         16654    16654           
  Misses         416      416           
  Partials       159      159           
Flag Coverage Δ
#functional 5.97% <0.00%> (ø)
#integration 10.06% <0.00%> (ø)
#unit 95.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/core-transactions/src/handlers/two/vote.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f649179...44cc12e. Read the comment docs.

@faustbrian faustbrian merged commit 75e9c21 into develop Oct 16, 2020
@ghost ghost deleted the fix/core-transactions/vote-bootstrap branch October 16, 2020 01:38
@ghost ghost removed the needsReview label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants