Skip to content

fix(magistrate): entity name only unique by type #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2020
Merged

fix(magistrate): entity name only unique by type #4008

merged 3 commits into from
Sep 8, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Sep 8, 2020

Summary

Entity name needs to be unique by type, instead of by type + subType currently.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High labels Sep 8, 2020
@faustbrian faustbrian merged commit 3b12c70 into 2.7 Sep 8, 2020
@ghost ghost deleted the fix/entity-name-unique-by-type branch September 8, 2020 13:07
@ghost ghost mentioned this pull request Sep 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristjank kristjank Awaiting requested review from kristjank

1 more reviewer

@faustbrian faustbrian faustbrian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@air1one @faustbrian