Skip to content

Conversation

@air1one
Copy link
Contributor

@air1one air1one commented Jun 19, 2020

Summary

Copy over hapi/nes so we have it under control inside core.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #3813 into develop will decrease coverage by 7.52%.
The diff coverage is 4.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3813      +/-   ##
===========================================
- Coverage    97.27%   89.75%   -7.53%     
===========================================
  Files          617      620       +3     
  Lines        13922    14769     +847     
  Branches      1636     1842     +206     
===========================================
- Hits         13543    13256     -287     
- Misses         118     1263    +1145     
+ Partials       261      250      -11     
Flag Coverage Δ
#functional 5.85% <0.00%> (-0.63%) ⬇️
#integration 9.60% <0.00%> (-0.59%) ⬇️
#unit 88.02% <4.20%> (-7.20%) ⬇️
Impacted Files Coverage Δ
packages/core-p2p/src/hapi-nes/client.ts 2.83% <2.83%> (ø)
packages/core-p2p/src/hapi-nes/socket.ts 2.89% <2.89%> (ø)
packages/core-p2p/src/hapi-nes/listener.ts 3.93% <3.93%> (ø)
packages/core-forger/src/client.ts 98.33% <100.00%> (-0.03%) ⬇️
packages/core-p2p/src/peer-connector.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/socket-server/server.ts 100.00% <100.00%> (ø)
...e-test-framework/src/matchers/functional/entity.ts 6.45% <0.00%> (-87.10%) ⬇️
...rypto/src/transactions/bridgechain-registration.ts 13.18% <0.00%> (-85.72%) ⬇️
...rate-crypto/src/transactions/bridgechain-update.ts 12.37% <0.00%> (-82.48%) ⬇️
...e-crypto/src/transactions/business-registration.ts 22.64% <0.00%> (-75.48%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587297b...385c5a3. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 19, 2020

This pull request introduces 2 alerts when merging d76a3c5 into d9fc0c0 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

@faustbrian
Copy link
Contributor

@air1one failing tests due to some outdated mocks

@air1one
Copy link
Contributor Author

air1one commented Jun 22, 2020

Yes will fix the tests and wrap this up 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants