Repository navigation
fix(core-forger): log warning when active delegates are under the required delegate count - #3611
Merged
Merged
Conversation
bertiespell
requested review from
air1one,
faustbrian and
kristjank
as code owners
March 23, 2020 09:39
Codecov Report
@@ Coverage Diff @@
## develop #3611 +/- ##
===========================================
+ Coverage 80.77% 80.78% +<.01%
===========================================
Files 439 439
Lines 10119 10121 +2
Branches 1300 1301 +1
===========================================
+ Hits 8174 8176 +2
Misses 1941 1941
Partials 4 4
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Mar 23, 2020
ghost
deleted the
fix/core-forger/active-delegate-count
branch
March 23, 2020 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Log a warning in the
DelegateTracker'shandlemethod when the number of active delegates is below the required delegate count.Without the total number of required delegates we are not able to accurately compute the next forgers.
Checklist