Skip to content

Conversation

@air1one
Copy link
Contributor

@air1one air1one commented Mar 9, 2020

Summary

AcceptBlockHandler apply block to tx pool before db.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #3590 into 2.6 will decrease coverage by 0.04%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6    #3590      +/-   ##
==========================================
- Coverage   66.12%   66.07%   -0.05%     
==========================================
  Files         440      441       +1     
  Lines       12481    12504      +23     
  Branches     1714     1717       +3     
==========================================
+ Hits         8253     8262       +9     
- Misses       4194     4208      +14     
  Partials       34       34
Impacted Files Coverage Δ
packages/core-transaction-pool/src/connection.ts 91.32% <0%> (-0.38%) ⬇️
...s/core-jest-matchers/src/functional/unconfirmed.ts 0% <0%> (ø)
...ain/src/processor/handlers/accept-block-handler.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03976a6...1a374b0. Read the comment docs.

@faustbrian faustbrian merged commit 21436df into 2.6 Mar 9, 2020
@ghost ghost deleted the fix/applyToRecipient-2.6 branch March 9, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants