Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-transactions): use findByPublicKey to set both publickey and address on the multisig wallet #3498

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Feb 13, 2020

Summary

Set the public key on the wallet when applying multisignature registration transaction. Before using findByAddress, it would only set the address, now using findByPublicKey it sets both address and public key.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

❗ No coverage uploaded for pull request base (2.6@b88806f). Click here to learn what that means.
The diff coverage is 80%.

Impacted file tree graph

@@          Coverage Diff           @@
##             2.6    #3498   +/-   ##
======================================
  Coverage       ?   66.15%           
======================================
  Files          ?      439           
  Lines          ?    12465           
  Branches       ?     1711           
======================================
  Hits           ?     8246           
  Misses         ?     4185           
  Partials       ?       34
Impacted Files Coverage Δ
.../core-transactions/src/handlers/multi-signature.ts 68.62% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88806f...c07911a. Read the comment docs.

@faustbrian faustbrian merged commit c5284aa into 2.6 Feb 14, 2020
@ghost ghost deleted the refactor/core-transactions/multisig-publicKey branch February 14, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants