Skip to content

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Jan 14, 2020

Summary

The schema used to validate seednodes uses isValidPeer which in addition to checking for localhost will refuse any ip that comes os.networkInterfaces(). But in this case the additional network interface restriction is not desired and therefore lifted.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #3391 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3391      +/-   ##
===========================================
+ Coverage    66.33%   66.34%   +<.01%     
===========================================
  Files          438      439       +1     
  Lines        12342    12345       +3     
  Branches      1676     1676              
===========================================
+ Hits          8187     8190       +3     
  Misses        4123     4123              
  Partials        32       32
Impacted Files Coverage Δ
packages/crypto/src/transactions/types/schemas.ts 100% <ø> (ø) ⬆️
packages/core-tester-cli/src/shared/htlc-secret.ts 100% <100%> (ø)
...ges/core-tester-cli/src/commands/send/htlc-lock.ts 67.85% <100%> (ø) ⬆️
...kages/core-transactions/src/handlers/htlc-claim.ts 88.37% <100%> (+0.13%) ⬆️
...es/core-tester-cli/src/commands/send/htlc-claim.ts 64% <100%> (ø) ⬆️
...ckages/crypto/src/transactions/types/htlc-claim.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f4d70...3edad6c. Read the comment docs.

@air1one air1one merged commit 2824ac6 into develop Jan 20, 2020
@ghost ghost deleted the fix/seednode-ip-validation branch January 20, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants