Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transactions): add ipfs exception handling #3217

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Nov 6, 2019

Summary

Fixes #3216.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Nov 6, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low labels Nov 6, 2019
@dated
Copy link
Contributor Author

dated commented Nov 6, 2019

I don't see how the failing e2e test could be related 🤔

@faustbrian
Copy link
Contributor

It's not related, caused by the latest master merge when any e2e/p2p tests fail.

@ghost
Copy link

ghost commented Nov 6, 2019

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 159098b into ArkEcosystem:develop Nov 6, 2019
@ghost
Copy link

ghost commented Nov 6, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the fix/ipfs-exceptions branch November 6, 2019 09:26
@dated dated mentioned this pull request Nov 12, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants