-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(crypto): overwrite arrays when merging milestones #3108
Conversation
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Thanks! Can you also try to write tests for what you mentioned in #3105 and here? The relevant tests would have to be added here: |
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged and marked as tier 3. It will earn you $50 USD. |
Summary
Instead of concatenating arrays, overwrite them with the
source
array. In the particular case ofminimumVersions
we don't want to keep older values around, this PR is a solution targeted at this case and is not intended as a general solution for merging arrays - although as of now theminimumVersions
array is the only array used in milestones.Possibly closes #3105.
Checklist