-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-api): sort peers by height, latency #3078
Merged
faustbrian
merged 22 commits into
ArkEcosystem:develop
from
dated:refactor/peers-orderby
Oct 21, 2019
Merged
refactor(core-api): sort peers by height, latency #3078
faustbrian
merged 22 commits into
ArkEcosystem:develop
from
dated:refactor/peers-orderby
Oct 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Medium
labels
Oct 16, 2019
This pull request introduces 1 alert when merging 47f5e9c into 8dbe404 - view on LGTM.com new alerts:
|
dated
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
October 16, 2019 15:21
dated
changed the title
refactor(core-api): sort peers by height, latency, port
refactor(core-api): sort peers by height, latency
Oct 16, 2019
dated
force-pushed
the
refactor/peers-orderby
branch
from
October 16, 2019 22:07
2b7be8c
to
4d411b3
Compare
dated
changed the title
refactor(core-api): sort peers by height, latency
[WIP] refactor(core-api): sort peers by height, latency
Oct 16, 2019
dated
changed the title
[WIP] refactor(core-api): sort peers by height, latency
refactor(core-api): sort peers by height, latency
Oct 17, 2019
ghost
mentioned this pull request
Oct 20, 2019
faustbrian
approved these changes
Oct 21, 2019
ghost
added
the
Status: Collaborator Approved
label
Oct 21, 2019
A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
removed
the
Status: Needs Review
label
Oct 21, 2019
vasild
added a commit
that referenced
this pull request
Oct 21, 2019
…og-messages * ArkEcosystem/core/develop: refactor(core-api): sort peers by height, latency (#3078)
ghost
mentioned this pull request
Oct 27, 2019
faustbrian
pushed a commit
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements ordering by height, latency and port on the peers endpoint. Closes #3079.
Checklist