Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-api): sort peers by height, latency #3078

Merged
merged 22 commits into from
Oct 21, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Oct 16, 2019

Summary

Implements ordering by height, latency and port on the peers endpoint. Closes #3079.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request introduces 1 alert when merging 47f5e9c into 8dbe404 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@dated dated marked this pull request as ready for review October 16, 2019 15:21
@dated dated changed the title refactor(core-api): sort peers by height, latency, port refactor(core-api): sort peers by height, latency Oct 16, 2019
@dated dated changed the title refactor(core-api): sort peers by height, latency [WIP] refactor(core-api): sort peers by height, latency Oct 16, 2019
@dated dated changed the title [WIP] refactor(core-api): sort peers by height, latency refactor(core-api): sort peers by height, latency Oct 17, 2019
@ghost
Copy link

ghost commented Oct 21, 2019

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 03fdf01 into ArkEcosystem:develop Oct 21, 2019
@ghost
Copy link

ghost commented Oct 21, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@ghost ghost removed the Status: Needs Review label Oct 21, 2019
@dated dated deleted the refactor/peers-orderby branch October 21, 2019 04:51
vasild added a commit that referenced this pull request Oct 21, 2019
…og-messages

* ArkEcosystem/core/develop:
  refactor(core-api): sort peers by height, latency (#3078)
vasild added a commit that referenced this pull request Oct 21, 2019
…allel-download

* ArkEcosystem/core/develop:
  refactor(core-api): sort peers by height, latency (#3078)
  fix: use strict comparison to decide if a transaction should be enabled (#3087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants