Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): add missing offset handling to /api/peers #3075

Merged
merged 3 commits into from
Oct 17, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Oct 16, 2019

Summary

Resolves #3074
Resolves #3080

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #3075 into develop will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3075      +/-   ##
===========================================
+ Coverage    65.73%   65.73%   +<.01%     
===========================================
  Files          425      425              
  Lines        11748    11755       +7     
  Branches      1606     1608       +2     
===========================================
+ Hits          7722     7727       +5     
- Misses        3991     3993       +2     
  Partials        35       35
Impacted Files Coverage Δ
packages/core-api/src/handlers/peers/controller.ts 90.62% <75%> (-5.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c88c4...c37eda7. Read the comment docs.

@faustbrian faustbrian merged commit 3bcc8fa into develop Oct 17, 2019
@ghost ghost deleted the fix/p2p-offset branch October 17, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants