Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core-magistrate): Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions #2967

Merged
merged 12 commits into from
Sep 27, 2019
Merged

refactor(core-magistrate): Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions #2967

merged 12 commits into from
Sep 27, 2019

Conversation

KovacZan
Copy link
Contributor

Summary

  • Name change from core-marketplace into core-magistrate.
  • Spited core-marketplace into two separated modules (core-magistrate-crypto and core-magistrate-transactions) .
  • Added additional functional tests for core-magistrate, testing second passphrase and multisig.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Sep 24, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost
Copy link

ghost commented Sep 24, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@faustbrian faustbrian changed the title core-magistrate(refactor): Split core-marketplace into core-magistrate-crypto and core… …-magistrate-transactions refactor(core-magistrate): Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions Sep 24, 2019
spkjp
spkjp suggested changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@spkjp spkjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some minor changes.

__tests__/e2e/lib/utils/sync.sh Outdated Show resolved Hide resolved
__tests__/e2e/lib/utils/sync.sh Outdated Show resolved Hide resolved
packages/core-magistrate-transactions/package.json Outdated Show resolved Hide resolved
packages/core-magistrate-transactions/src/events.ts Outdated Show resolved Hide resolved
scripts/docker/templates/devnet/entrypoint.sh Outdated Show resolved Hide resolved
scripts/docker/templates/testnet/entrypoint.sh Outdated Show resolved Hide resolved
@KovacZan KovacZan requested a review from spkjp September 26, 2019 21:30
spkjp
spkjp previously approved these changes Sep 27, 2019
View reviewed changes
@ghost
Copy link

ghost commented Sep 27, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@spkjp spkjp self-requested a review September 27, 2019 23:56
@ghost
Copy link

ghost commented Sep 27, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@spkjp spkjp merged commit 6c6c96c into ArkEcosystem:develop Sep 27, 2019
@ghost
Copy link

ghost commented Sep 27, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ghost ghost mentioned this pull request Sep 29, 2019
Closed
vasild added a commit that referenced this pull request Oct 1, 2019
@vasild
Merge remote-tracking branch 'ArkEcosystem/core/develop' into snapsho…
c3151ab 
…ts-nonce

* ArkEcosystem/core/develop:
  fix(deps): update dependency @hapi/boom to v8 (#2988)
  feat(crypto): allow passing height to `configManager.isNewMilestone` (#3001)
  ci: update branch patterns to new format
  refactor: remove asset migration heuristic (#2999)
  chore(deps): update dependency typesync to ^0.6.0 (#2981)
  refactor(core): use default heap size regardless of available memory (#2998)
  chore(deps): update dependency cross-env to v6 (#2985)
  chore(deps): update dependency rimraf to v3 (#2987)
  refactor: core-magistrate-crypto export namespaces (#2980)
  feat: multiSignWif (#2979)
  fix(core-snapshots): export/import transactions' type_group (#2996)
  chore(deps): update dependency @types/newrelic to v5 (#2984)
  fix(deps): update dependency node-forge to ^0.9.0 (#2983)
  feat(core-api): find htlc unlock transactions (#2976)
  chore(deps): update dependency del-cli to v3 (#2986)
  fix(deps): update dependency cli-progress to v3 (#2990)
  fix(deps): update dependency winston-daily-rotate-file to v4 (#2992)
  fix(core-api): missing orderBy (#2974)
  feat(core): allow CLI command configurations (#2972)
  refactor(core-magistrate):  Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions (#2967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spkjp spkjp spkjp approved these changes

@air1one air1one Awaiting requested review from air1one

@faustbrian faustbrian Awaiting requested review from faustbrian

@kristjank kristjank Awaiting requested review from kristjank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KovacZan @spkjp