fix(core-transaction-pool): sort by fee, nonce #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge 3923c37 wrongly removed the method sortAll() from memory.ts. This method was sorting transactions in the pool by fee, nonce (sorted by highest fee first, but transactions from the same sender must be sorted lowest nonce first). Restore the sortAll() method as of before the merge and adapt it to use the calculateTransactionExpiration() method for expiration sorting.
vasild
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
spkjp
approved these changes
Sep 18, 2019
ghost
deleted the
spkjp
pushed a commit
that referenced
this pull request
Sep 19, 2019
The merge 3923c37 wrongly removed the method sortAll() from memory.ts. This method was sorting transactions in the pool by fee, nonce (sorted by highest fee first, but transactions from the same sender must be sorted lowest nonce first). Restore the sortAll() method as of before the merge and adapt it to use the calculateTransactionExpiration() method for expiration sorting.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge 3923c37 wrongly removed the method sortAll() from memory.ts.
This method was sorting transactions in the pool by fee, nonce (sorted
by highest fee first, but transactions from the same sender must be
sorted lowest nonce first).
Restore the sortAll() method as of before the merge and adapt it to use
the calculateTransactionExpiration() method for expiration sorting.
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: