Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): /wallets/{id}/transactions search parameters #2923

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Sep 13, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #2923 into develop will decrease coverage by 0.4%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2923      +/-   ##
===========================================
- Coverage    68.15%   67.75%   -0.41%     
===========================================
  Files          406      424      +18     
  Lines         9773     9929     +156     
  Branches       508      513       +5     
===========================================
+ Hits          6661     6727      +66     
- Misses        3070     3158      +88     
- Partials        42       44       +2
Impacted Files Coverage Δ
...kages/core-api/src/handlers/transactions/schema.ts 100% <ø> (ø) ⬆️
...c/repositories/transactions-business-repository.ts 90% <ø> (-0.91%) ⬇️
packages/core-api/src/handlers/wallets/schema.ts 100% <ø> (ø) ⬆️
...database-postgres/src/repositories/transactions.ts 25.49% <0%> (-1.05%) ⬇️
packages/core-api/src/handlers/wallets/methods.ts 97.95% <100%> (+0.13%) ⬆️
...s/core-interfaces/src/core-database/event-types.ts 0% <0%> (ø)
packages/core-transaction-pool/src/plugin.ts 100% <0%> (ø)
...aces/src/core-database/search/search-parameters.ts 0% <0%> (ø)
packages/core-blockchain/src/plugin.ts 0% <0%> (ø)
packages/core-wallet-api/src/plugin.ts 0% <0%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c98bf...1160631. Read the comment docs.

@faustbrian faustbrian merged commit af87eaa into develop Sep 13, 2019
@ghost ghost deleted the fix/core-api/transaction-search branch September 13, 2019 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants