Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-transactions): htlc implementation #2915

Merged
merged 16 commits into from
Sep 18, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Sep 10, 2019

  • Add missing interfaces
  • Unix timestamp => epoch timestamp
  • Deduplicate throwIfCannotBeApplied logic (already had missing checks)
  • Don't store full transactions as locks on the wallet

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

faustbrian
faustbrian previously approved these changes Sep 12, 2019
@spkjp spkjp force-pushed the refactor/core-transactions/htlc branch 2 times, most recently from 9ddc91e to 8c78c8d Compare September 18, 2019 02:05
@spkjp spkjp merged commit c5d7239 into develop Sep 18, 2019
@ghost ghost deleted the refactor/core-transactions/htlc branch September 18, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants