fix(core-blockchain): only shift milestoneHeights[] if at that height #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code would remove entires from milestoneHeights[] even if no milestone is hit (due to e.g. "currentTransactionsCount >= 150" being true).
vasild
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2904 +/- ##
========================================
Coverage 68.08% 68.08%
========================================
Files 405 405
Lines 9733 9733
Branches 502 460 -42
========================================
Hits 6627 6627
- Misses 3065 3069 +4
+ Partials 41 37 -4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #2904 +/- ##
========================================
Coverage 68.08% 68.08%
========================================
Files 405 405
Lines 9733 9733
Branches 502 460 -42
========================================
Hits 6627 6627
- Misses 3065 3069 +4
+ Partials 41 37 -4
Continue to review full report at Codecov.
|
spkjp
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
No idea why some of the checks are failing. (@faustbrian ?)
LGTM otherwise.
ghost
deleted the
vasild
added a commit
that referenced
this pull request
Sep 5, 2019
…k-chained-verbose * ArkEcosystem/core/develop: test: mock missing wsServer release: 2.5.24 (#2908) fix(core-p2p): terminate blocked client connections fix(core-p2p): drop connections with malformed messages fix(core-api): return block timestamp for v2 transactions (#2906) fix(core-blockchain): only shift milestoneHeights[] if at that height (#2904) fix(crypto): use `anyOf` for transactions schema (#2894) fix(core-webhooks): cast params in condition checks (#2887) feat(core-p2p): use compression on the p2p level (#2886)
vasild
added a commit
that referenced
this pull request
Sep 5, 2019
…ly-chained-check * ArkEcosystem/core/develop: test: mock missing wsServer release: 2.5.24 (#2908) fix(core-p2p): terminate blocked client connections fix(core-p2p): drop connections with malformed messages fix(core-api): return block timestamp for v2 transactions (#2906) fix(core-blockchain): only shift milestoneHeights[] if at that height (#2904) fix(crypto): use `anyOf` for transactions schema (#2894) fix(core-webhooks): cast params in condition checks (#2887) feat(core-p2p): use compression on the p2p level (#2886)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code would remove entires from milestoneHeights[] even if
no milestone is hit (due to e.g. "currentTransactionsCount >= 150" being
true).
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: