Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-transactions): register wallet attributes before accessing them #2867

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Aug 7, 2019

Transaction types now have to register attributes before they can access them. Trying to read/write an unknown attribute at runtime will cause an error now.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #2867 into develop will increase coverage by 0.06%.
The diff coverage is 92.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2867      +/-   ##
===========================================
+ Coverage    67.09%   67.16%   +0.06%     
===========================================
  Files          379      379              
  Lines         8996     9021      +25     
  Branches       469      432      -37     
===========================================
+ Hits          6036     6059      +23     
- Misses        2922     2928       +6     
+ Partials        38       34       -4
Impacted Files Coverage Δ
...ages/core-transactions/src/handlers/transaction.ts 62.96% <ø> (ø) ⬆️
...core-transactions/src/handlers/second-signature.ts 70% <100%> (+1.57%) ⬆️
...transactions/src/handlers/delegate-registration.ts 42.85% <100%> (+1.03%) ⬆️
packages/core-state/src/wallets/wallet.ts 88.76% <100%> (+0.81%) ⬆️
...-transactions/src/handlers/delegate-resignation.ts 70.83% <100%> (+1.26%) ⬆️
.../core-transactions/src/handlers/multi-signature.ts 72.97% <100%> (+0.75%) ⬆️
packages/core-transactions/src/handlers/vote.ts 65.9% <100%> (+0.79%) ⬆️
packages/core-transactions/src/handlers/ipfs.ts 76% <100%> (+1%) ⬆️
...es/core-transactions/src/handlers/multi-payment.ts 81.25% <100%> (+0.6%) ⬆️
...ackages/core-transactions/src/handlers/transfer.ts 65% <100%> (+1.84%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79dcbe0...022d3c3. Read the comment docs.

@faustbrian faustbrian merged commit 3c39180 into develop Aug 7, 2019
@ghost ghost deleted the feat/core-transactions/known-wallet-attributes branch August 7, 2019 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants