Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement AIP 103 #2858

Merged
merged 35 commits into from
Aug 20, 2019
Merged

feat: Implement AIP 103 #2858

merged 35 commits into from
Aug 20, 2019

Conversation

KovacZan
Copy link
Contributor

@KovacZan KovacZan commented Aug 1, 2019

Implement AIP 103 https://github.com/ArkEcosystem/AIPs/blob/master/AIPS/aip-103.md

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@faustbrian faustbrian changed the base branch from 2.6 to develop August 6, 2019 07:43
@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@7da2373). Click here to learn what that means.
The diff coverage is 76.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2858   +/-   ##
==========================================
  Coverage           ?   67.81%           
==========================================
  Files              ?      403           
  Lines              ?     9649           
  Branches           ?      438           
==========================================
  Hits               ?     6543           
  Misses             ?     3072           
  Partials           ?       34
Impacted Files Coverage Δ
...s/core-marketplace/src/marketplace-transactions.ts 100% <100%> (ø)
packages/core-marketplace/src/wallet-manager.ts 100% <100%> (ø)
...place/src/transactions/bridgechain-registration.ts 100% <100%> (ø)
...lace/src/transactions/utils/bridgechain-schemas.ts 100% <100%> (ø)
...ketplace/src/transactions/utils/business-schema.ts 100% <100%> (ø)
...re-marketplace/src/transactions/business-update.ts 100% <100%> (ø)
...arketplace/src/builders/bridgechain-resignation.ts 100% <100%> (ø)
...ore-marketplace/src/builders/bridgechain-update.ts 100% <100%> (ø)
...rketplace/src/builders/bridgechain-registration.ts 100% <100%> (ø)
...e-marketplace/src/builders/business-resignation.ts 100% <100%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da2373...211aecc. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2019

This pull request introduces 1 alert when merging 2dd75ee into 7da2373 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@KovacZan KovacZan marked this pull request as ready for review August 16, 2019 12:49
@ghost
Copy link

ghost commented Aug 20, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@spkjp spkjp merged commit f3ed2f9 into ArkEcosystem:develop Aug 20, 2019
@ghost
Copy link

ghost commented Aug 20, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ghost ghost removed the Status: In Progress label Aug 20, 2019
@spkjp spkjp mentioned this pull request Aug 27, 2019
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants