feat: Implement AIP 102 (HTLC) #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after removing timelock transfer so that we don't have any "hole"
ghost
added
Make abstract transaction handler unaware of child htlc implementation + sha256 for HTLC hash instead of hash256
|
The ci/circleci: node10-functional job is failing as of 02d3dcbb95480123d0e0488e08317d86297a4282. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
don't allow tx to enter pool if the associated lock tx id is not found
+ fix lockWallet.locks strange issue (see comments)
18 tasks
they were missing some properties
update after wallets index change in 2.6
also handle nonce for htlc transactions
related to zero-fee htlc claim and refund + some fixes for htlc bootstrap functions
+ fix failing core-api test
spkjp
approved these changes
Aug 1, 2019
ghost
deleted the
Moustikitos
reviewed
Aug 21, 2019
|
|
||
| const buffer: ByteBuffer = new ByteBuffer(8 + 32 + 8 + 21, true); | ||
|
|
||
| buffer.writeUint64(+data.amount); |
There was a problem hiding this comment.
I think data.amount is already packed in the common part of transaction serialization. It is a doublon serializing it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement AIP 102 HTLC : https://github.com/ArkEcosystem/AIPs/blob/master/AIPS/aip-102.md
Edit: ready for reviews / merge.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: