Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not sort transactions in forger / update purgeByBlock logic for handling nonces #2678

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jun 10, 2019

A few fixes related to nonces :

  • (core-forger) do not sort transactions when forging (we already get sorted transactions from relay)
  • (core-transaction-pool) update purgeByBlock to manage reverting transactions with higher nonces

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@spkjp spkjp merged commit 2dd318f into 2.6 Jun 12, 2019
@ghost ghost deleted the fix/nonces branch June 12, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants