chore: add commands to check for missing dependencies and types

.circleci/config.yml

@@ -52,7 +52,6 @@ jobs:
       - save_cache:
           key: 'core-node10-{{ checksum "checksum.txt" }}-unit-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -141,7 +140,6 @@ jobs:
       - save_cache:
           key: 'core-node11-{{ checksum "checksum.txt" }}-unit-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -230,7 +228,6 @@ jobs:
       - save_cache:
           key: 'core-node12-{{ checksum "checksum.txt" }}-unit-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -327,7 +324,6 @@ jobs:
       - save_cache:
           key: 'core-node10-{{ checksum "checksum.txt" }}-functional-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -424,7 +420,6 @@ jobs:
       - save_cache:
           key: 'core-node11-{{ checksum "checksum.txt" }}-functional-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -521,7 +516,6 @@ jobs:
       - save_cache:
           key: 'core-node12-{{ checksum "checksum.txt" }}-functional-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -618,7 +612,6 @@ jobs:
       - save_cache:
           key: 'core-node10-{{ checksum "checksum.txt" }}-1-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -740,7 +733,6 @@ jobs:
       - save_cache:
           key: 'core-node11-{{ checksum "checksum.txt" }}-1-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -862,7 +854,6 @@ jobs:
       - save_cache:
           key: 'core-node12-{{ checksum "checksum.txt" }}-1-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -973,7 +964,6 @@ jobs:
       - save_cache:
           key: 'core-node10-{{ checksum "checksum.txt" }}-benchmark-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -1044,7 +1034,6 @@ jobs:
       - save_cache:
           key: 'core-node11-{{ checksum "checksum.txt" }}-benchmark-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -1115,7 +1104,6 @@ jobs:
       - save_cache:
           key: 'core-node12-{{ checksum "checksum.txt" }}-benchmark-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -1194,7 +1182,6 @@ jobs:
       - save_cache:
           key: 'ark-node10-e2e-{{ checksum "checksum.txt" }}-1-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -1315,7 +1302,6 @@ jobs:
       - save_cache:
           key: 'ark-node11-e2e-{{ checksum "checksum.txt" }}-2-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -1436,7 +1422,6 @@ jobs:
       - save_cache:
           key: 'ark-node12-e2e-{{ checksum "checksum.txt" }}-2-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -1560,7 +1545,6 @@ jobs:
       - save_cache:
           key: 'core-node10-{{ checksum "checksum.txt" }}-1-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -1682,7 +1666,6 @@ jobs:
       - save_cache:
           key: 'core-node11-{{ checksum "checksum.txt" }}-1-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules
@@ -1804,7 +1787,6 @@ jobs:
       - save_cache:
           key: 'core-node12-{{ checksum "checksum.txt" }}-1-1'
           paths:
-            - ./packages/.DS_Store/node_modules
             - ./packages/core/node_modules
             - ./packages/core-api/node_modules
             - ./packages/core-blockchain/node_modules

package.json

@@ -43,7 +43,10 @@
         "publish:latest": "cross-env-shell ./scripts/publish/latest.sh",
         "upgrade": "cross-env-shell ./scripts/upgrade.sh",
         "version": "cross-env-shell ./scripts/version.sh",
-        "deps": "cross-env-shell ./scripts/deps.sh",
+        "deps": "cross-env-shell ./scripts/deps/update.sh",
+        "deps:missing": "node ./scripts/deps/missing.js",
+        "deps:unused": "node ./scripts/deps/unused.js",
+        "deps:types": "./node_modules/typesync/bin/typesync",
         "docker": "node ./scripts/docker/generate-docker.js",
         "bench": "node benchmark/index.js"
     },
@@ -55,6 +58,7 @@
         "@sindresorhus/tsconfig": "^0.3.0",
         "@types/babel__core": "^7.1.2",
         "@types/create-hash": "^1.2.0",
+        "@types/depcheck": "^0.6.0",
         "@types/jest": "^24.0.13",
         "@types/js-yaml": "^3.12.1",
         "@types/nock": "^10.0.3",
@@ -69,6 +73,7 @@
         "create-hash": "^1.2.0",
         "cross-env": "^5.2.0",
         "del-cli": "^1.1.0",
+        "depcheck": "^0.8.0",
         "husky": "^2.3.0",
         "jest": "^24.8.0",
         "jest-extended": "^0.11.1",
@@ -85,6 +90,7 @@
         "tslint": "^5.16.0",
         "tslint-config-prettier": "^1.18.0",
         "typescript": "^3.4.5",
+        "typesync": "^0.5.1",
         "uuid": "^3.3.2"
     },
     "workspaces": [

packages/core-api/package.json

@@ -38,6 +38,7 @@
         "hapi-pagination": "https://github.com/faustbrian/hapi-pagination",
         "hapi-rate-limit": "^3.1.2",
         "ip": "^1.1.5",
+        "lodash.groupby": "^4.6.0",
         "lodash.orderby": "^4.6.0",
         "lodash.partition": "^4.6.0",
         "lodash.snakecase": "^4.1.1",
@@ -48,6 +49,7 @@
         "@types/hapi__boom": "^7.4.0",
         "@types/hapi__joi": "^15.0.1",
         "@types/ip": "^1.1.0",
+        "@types/lodash.groupby": "^4.6.6",
         "@types/lodash.orderby": "^4.6.6",
         "@types/lodash.partition": "^4.6.6",
         "@types/lodash.snakecase": "^4.1.6",

packages/core-jest-matchers/package.json

@@ -34,6 +34,7 @@
     },
     "devDependencies": {
         "@types/bip39": "^2.4.2",
+        "@types/got": "^9.4.4",
         "@types/lodash.get": "^4.4.6",
         "@types/lodash.isequal": "^4.5.5",
         "@types/lodash.sortby": "^4.7.6"

packages/core-transaction-pool/package.json

@@ -47,6 +47,7 @@
         "@types/better-sqlite3": "^5.4.0",
         "@types/bip39": "^2.4.2",
         "@types/fs-extra": "^7.0.0",
+        "@types/lodash.camelcase": "^4.3.6",
         "@types/lodash.clonedeep": "^4.5.6",
         "@types/pluralize": "^0.0.29",
         "@types/random-seed": "^0.3.3",

packages/core/package.json

@@ -69,6 +69,7 @@
         "@oclif/plugin-not-found": "^1.2.2",
         "@oclif/plugin-plugins": "^1.7.8",
         "bip39": "^3.0.2",
+        "bytebuffer": "^5.0.1",
         "chalk": "^2.4.2",
         "clear": "^0.1.0",
         "cli-progress": "^2.1.1",
@@ -93,6 +94,7 @@
     },
     "devDependencies": {
         "@types/bip39": "^2.4.2",
+        "@types/bytebuffer": "^5.0.40",
         "@types/cli-progress": "^1.8.1",
         "@types/execa": "^0.9.0",
         "@types/fast-levenshtein": "^0.0.1",

packages/crypto/package.json

@@ -53,6 +53,7 @@
     "devDependencies": {
         "@types/bip32": "^1.0.2",
         "@types/bip39": "^2.4.2",
+        "@types/bs58": "^4.0.0",
         "@types/buffer-xor": "^2.0.0",
         "@types/bytebuffer": "^5.0.40",
         "@types/hapi__joi": "^15.0.1",

scripts/deps/missing.js

@@ -0,0 +1,41 @@
+const depcheck = require("depcheck");
+const {
+    resolve
+} = require("path");
+const {
+    lstatSync,
+    readdirSync
+} = require("fs");
+
+const source = resolve(__dirname, "../../packages");
+
+const pkgs = readdirSync(source)
+    .filter(name => lstatSync(`${source}/${name}`).isDirectory())
+    .sort();
+
+for (const pkg of pkgs) {
+    depcheck(`${source}/${pkg}`, {
+        ignoreDirs: [
+            '__tests__',
+            'benchmark',
+            'dist',
+            'docker',
+            'scripts',
+        ],
+        ignoreMatches: [
+            '@types/*'
+        ],
+    }, unused => {
+        const missing = Object.keys(unused.missing);
+
+        if (missing.length > 0) {
+            console.log(`[FAIL] ${pkg}`)
+
+            for (const dep of missing) {
+                console.log(`lerna add ${dep} --scope=@arkecosystem/${pkg}`)
+            }
+        } else {
+            console.log(`[PASS] ${pkg}`)
+        }
+    });
+}

scripts/deps/unused.js

@@ -0,0 +1,50 @@
+const depcheck = require("depcheck");
+const {
+    resolve
+} = require("path");
+const {
+    lstatSync,
+    readdirSync
+} = require("fs");
+
+const source = resolve(__dirname, "../../packages");
+
+const pkgs = readdirSync(source)
+    .filter(name => lstatSync(`${source}/${name}`).isDirectory())
+    .sort();
+
+for (const pkg of pkgs) {
+    depcheck(`${source}/${pkg}`, {
+        ignoreDirs: [
+            '__tests__',
+            'benchmark',
+            'dist',
+            'docker',
+            'scripts',
+        ],
+        ignoreMatches: [
+            '@types/*'
+        ],
+    }, unused => {
+        const dependencies = Object.values(unused.dependencies);
+        const devDependencies = Object.values(unused.devDependencies);
+
+        if (dependencies || devDependencies) {
+            console.log(`[FAIL] ${pkg}`)
+
+            if (dependencies.length > 0) {
+                for (const dep of dependencies) {
+                    console.log(`[PRO] ${dep}`)
+                }
+            }
+
+            if (devDependencies.length > 0) {
+                for (const dep of devDependencies) {
+                    console.log(`[DEV] ${dep}`)
+                }
+            }
+        } else {
+            console.log(`[PASS] ${pkg}`)
+        }
+    });
+}

scripts/deps.sh → scripts/deps/update.sh

@@ -3,6 +3,6 @@
 for dir in `find packages -mindepth 1 -maxdepth 1 -type d | sort -nr`; do
     cd $dir
     echo $PWD
-    cd ../..
+    cd ../../..
     ./node_modules/npm-check-updates/bin/npm-check-updates -u
 done