-
Notifications
You must be signed in to change notification settings - Fork 285
feat: initial nonce implementation #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The ci/circleci: test-node10-integration-1 job is failing as of fe8175ae7d68e0df0003cca81043b2632947d036. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## 2.6 #2573 +/- ##
==========================================
- Coverage 66.82% 66.61% -0.22%
==========================================
Files 406 422 +16
Lines 8883 9018 +135
Branches 460 463 +3
==========================================
+ Hits 5936 6007 +71
- Misses 2892 2954 +62
- Partials 55 57 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 2.6 #2573 +/- ##
==========================================
- Coverage 66.82% 66.78% -0.05%
==========================================
Files 406 422 +16
Lines 8883 9074 +191
Branches 419 469 +50
==========================================
+ Hits 5936 6060 +124
- Misses 2894 2956 +62
- Partials 53 58 +5
Continue to review full report at Codecov.
|
Sort transactions in the pool by fee (highest fee first), as before. However, if we find a transaction from the same sender with a higher nonce earlier in the sorted array, then move that transaction later in the array. Ie don't allow transactions with higher nonce before transactions with a lower nonce (for the same sender).
…ve-incdec * ArkEcosystem/core/2.6: feat: initial nonce implementation (#2573) Merge develop into 2.5 (#2600) refactor(core-json-rpc): use blockId schema for validation (#2596) chore(core-database-postgres): add core-state dependency (#2598) fix(core-database-postgres): use day instead of date (#2595) refactor: use dayjs as it now has official UTC support (#2592) refactor(core-json-rpc): improved version of #2593 release: 2.3.23 (#2594) fix(core-json-rpc): allow use of old and new block IDs (#2593) fix(core-p2p): do not suspend peer for `AppNotReady` (#2590) chore(changelog): add latest changes for 2.4.0 (#2591) chore(ci): setup node.js 12 on CircleCI (#2474) fix(core-blockchain): divide blocks into smaller chunks for batch processing (#2586) refactor(crypto): fallback to ECDSA signature for version 2 transactions (#2584) fix(core-p2p): don't cause suspensions for unresponsive plugins (#2583) fix(core-p2p): don't cause suspensions for unresponsive plugins test(core-api): set p2p port on dummy peer feat(core): command to generate network configuration (#2582) fix(core-blockchain): delete bad rounds after unclean shutdown (#2581) feat(core-p2p): don't trust headers and verify config and plugin connectivity of peers (#2559) refactor: use ApplicationEvents enum instead of string (#2580) refactor(core-api): enforce "application/json" as content-type refactor(core-api): use pagination configuration limit test(e2e): remove version assertions chore(ci): update CircleCI configuration test(core-tester-cli): update API mock URLs refactor(core-api): register /api/v2 as a transition period fallback (#2578) test(core-api): use address identity refactor(corer-api): remove the legacy API (#2439)
Summary
Initial implementation of #2086.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
Checklist