Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove support for old release channels #2476

Merged
merged 2 commits into from
Apr 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/commands/config/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $ ark config:cli --channel=next
}),
channel: flags.string({
description: "the name of the channel that should be used",
options: ["alpha", "beta", "rc", "next", "latest"],
options: ["next", "latest"],
}),
};

Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/commands/config/forger/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ $ ark config:forger --method=bip39
public async run(): Promise<void> {
const { flags } = await this.parseWithNetwork(ForgerCommand);

delete flags.suffix;

if (flags.method === "bip38") {
return BIP38Command.run(this.formatFlags(flags));
}
Expand All @@ -53,8 +55,6 @@ $ ark config:forger --method=bip39
this.abortWithInvalidInput();
}

delete flags.suffix;

response = { ...flags, ...response };

if (response.method === "bip38") {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/helpers/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export async function installFromChannel(pkg, channel) {
}

export function getRegistryChannel(config: IConfig): string {
const channels: string[] = ["alpha", "beta", "rc", "next"];
const channels: string[] = ["next"];

let channel: string = "latest";
for (const item of channels) {
Expand Down
5 changes: 1 addition & 4 deletions packages/core/src/hooks/init/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ export const init: Hook<"init"> = async function({ id, config }) {
)}. Review the latest release and run "ark update" once you wish to update.`,
);

const branch = {
alpha: "develop",
beta: "develop",
rc: "develop",
const branch: Record<string, string> = {
next: "develop",
latest: "master",
}[state.channel];
Expand Down