fix(core-transaction-pool): invalid transactions after rollback #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ci/circleci: test-node11-2 job is failing as of 0c6f5c061d4ddc4ed302311dc05277a4029340da. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
The ci/circleci: test-node10-2 job is failing as of 0c6f5c061d4ddc4ed302311dc05277a4029340da. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## 2.2 #2217 +/- ##
=======================================
Coverage 79.23% 79.23%
=======================================
Files 331 331
Lines 7916 7916
Branches 1115 1098 -17
=======================================
Hits 6272 6272
Misses 1612 1612
Partials 32 32
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Mar 9, 2019
faustbrian
added a commit
that referenced
this pull request
Mar 10, 2019
ghost
mentioned this pull request
12 tasks
vasild
added a commit
that referenced
this pull request
Mar 11, 2019
* ArkEcosystem/core/develop: chore: update dependencies and remove unused imports (#2212) fix(core-tester-cli): Don't hide errors from HTTP failures (#2223) chore: update CircleCI config chore: use yarn setup on CircleCI fix: resolve core-tester-utils conflicts and various errors chore: yarn.lock chore: bump versions chore: resolve conflicts refactor(core): allow to provide yes/no callbacks for confirm feat(core): suggest another command if the requested one was not found fix(core): only quote string flags that contain whitespace fix(core-blockchain): node stuck during sync (#2220) docs: add #2217 to the changelog refactor(core): use restart instead of reload refactor(core): log the stderr output for pm2 errors refactor(core): handle pm2 errors outside of the process manager refactor(core): log the pm2 status if it is unknown refactor(core-p2p): log concise error message instead of dumping the reply (#2215) fix(core-blockchain): return if last downloaded block changed (#2216) fix(core-transaction-pool): invalid transactions after rollback (#2217) feat(core-p2p): Don't spoil the quorum if the peer has !forgingAllowed (#2214) fix(core): escape string flags docs: add #2207 to the changelog refactor(core-forger): Increase timeout for getting the network state (#2208) fix: vote balance update (#2207) fix(core): exclude undefined values from string casting build(docker): use latest release in production images chore: install stable release via setup script test(core-p2p): toBeGreaterThanOrEqual instead of toBe release: 2.2.0 chore: bump version fix: schema fix: max payload size fix: quorum issues (#2091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
After a rollback, the transaction pool could end up with transactions where the block timestamp is used, therefore failing verification and resulting in invalid blocks:
This does not apply to
develop, because of the much stricter separation of the transaction data introduced with AIP29.This also caused the following errors:
Types of changes
Checklist