refactor(crypto): introduce vendorFieldLength constant in milestones

packages/core-container/__tests__/__stubs__/config/milestones.json

@@ -22,14 +22,15 @@
                 "multiPayment": 0,
                 "delegateResignation": 0
             }
-        }
+        },
+        "vendorFieldLength": 64
     },
     {
         "height": 75600,
         "reward": 200000000
     },
     {
         "height": 100000,
-        "vendorField255": true
+        "vendorFieldLength": 255
     }
 ]

packages/crypto/__tests__/transactions/deserializers/transaction.test.ts

@@ -54,8 +54,8 @@ describe("Transaction serializer / deserializer", () => {
             expect(deserialized.data.recipientId).toBe(transfer.recipientId);
         });
 
-        it("should ser/deserialize with long vendorfield when vendorField255 milestone is active", () => {
-            configManager.getMilestone().vendorField255 = true;
+        it("should ser/deserialize with long vendorfield when vendorFieldLength=255 milestone is active", () => {
+            configManager.getMilestone().vendorFieldLength = 255;
 
             const transferWithLongVendorfield = client
                 .getBuilder()
@@ -77,10 +77,10 @@ describe("Transaction serializer / deserializer", () => {
             expect(deserialized.data.vendorFieldHex).toHaveLength(510);
             expect(deserialized.data.vendorField).toEqual("y".repeat(255));
 
-            configManager.getMilestone().vendorField255 = false;
+            configManager.getMilestone().vendorFieldLength = 64;
         });
 
-        it("should not ser/deserialize long vendorfield when vendorField255 milestone is not active", () => {
+        it("should not ser/deserialize long vendorfield when vendorFieldLength=255 milestone is not active", () => {
             const transferWithLongVendorfield = client
                 .getBuilder()
                 .transfer()

packages/crypto/__tests__/validation/formats.test.ts

@@ -27,15 +27,15 @@ describe("format vendorField", () => {
     });
 
     it("should be ok with up to 255 bytes with milestone ", () => {
-        configManager.getMilestone().vendorField255 = true;
+        configManager.getMilestone().vendorFieldLength = 255;
         const schema = { type: "string", format: "vendorField" };
         const validate = ajv.compile(schema);
         expect(validate("a".repeat(65))).toBeTrue();
         expect(validate("⊁".repeat(85))).toBeTrue();
         expect(validate("a".repeat(256))).toBeFalse();
         expect(validate("⊁".repeat(86))).toBeFalse();
 
-        configManager.getMilestone().vendorField255 = false;
+        configManager.getMilestone().vendorFieldLength = 64;
     });
 });
 
@@ -49,15 +49,15 @@ describe("format vendorFieldHex", () => {
         expect(validate("⊁".repeat(22))).toBeFalse();
     });
 
-    it("should be ok with 510 hex when milestone vendorField255 is active", () => {
-        configManager.getMilestone().vendorField255 = true;
+    it("should be ok with 510 hex when milestone vendorFieldLength=255 is active", () => {
+        configManager.getMilestone().vendorFieldLength = 255;
         const schema = { type: "string", format: "vendorFieldHex" };
         const validate = ajv.compile(schema);
 
         expect(validate("affe".repeat(127))).toBeTrue();
         expect(validate("affe".repeat(128))).toBeFalse();
 
-        configManager.getMilestone().vendorField255 = false;
+        configManager.getMilestone().vendorFieldLength = 64;
     });
 
     it("should not be ok with non hex", () => {

packages/crypto/src/networks/devnet/milestones.json

@@ -23,7 +23,8 @@
                 "delegateResignation": 0
             }
         },
-        "ignoreInvalidSecondSignatureField": true
+        "ignoreInvalidSecondSignatureField": true,
+        "vendorFieldLength": 64
     },
     {
         "height": 10800,
@@ -49,6 +50,6 @@
     },
     {
         "height": 1750000,
-        "vendorField255": true
+        "vendorFieldLength": 255
     }
 ]

packages/crypto/src/networks/mainnet/milestones.json

@@ -22,7 +22,8 @@
                 "multiPayment": 0,
                 "delegateResignation": 0
             }
-        }
+        },
+        "vendorFieldLength": 64
     },
     {
         "height": 75600,
@@ -37,6 +38,6 @@
     },
     {
         "height": 8000000,
-        "vendorField255": true
+        "vendorFieldLength": 255
     }
 ]

packages/crypto/src/networks/testnet/milestones.json

@@ -22,14 +22,15 @@
                 "multiPayment": 0,
                 "delegateResignation": 0
             }
-        }
+        },
+        "vendorFieldLength": 64
     },
     {
         "height": 75600,
         "reward": 200000000
     },
     {
         "height": 100000,
-        "vendorField255": true
+        "vendorFieldLength": 255
     }
 ]

packages/crypto/src/networks/unitnet/milestones.json

@@ -22,14 +22,15 @@
                 "multiPayment": 0,
                 "delegateResignation": 0
             }
-        }
+        },
+        "vendorFieldLength": 64
     },
     {
         "height": 75600,
         "reward": 200000000
     },
     {
         "height": 100000,
-        "vendorField255": true
+        "vendorFieldLength": 255
     }
 ]

packages/crypto/src/utils.ts

@@ -72,12 +72,6 @@ export const isGenesisTransaction = (id: string): boolean => {
     return genesisTransactions[id];
 };
 
-export const maxVendorFieldLength = (height?: number): number => {
-    if (configManager.getMilestone(height).vendorField255) {
-        return 255;
-    }
-
-    return 64;
-};
+export const maxVendorFieldLength = (height?: number): number => configManager.getMilestone(height).vendorFieldLength;
 
 export { Bignum };