Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crypto): Switch block id to full SHA256 #2156

Merged
merged 40 commits into from
Mar 13, 2019
Merged

feat(crypto): Switch block id to full SHA256 #2156

Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
fce548c
feat(crypto): Switch block id to full SHA256
vasild Feb 25, 2019
8758d01
Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid
vasild Feb 27, 2019
3915086
fix(crypto): Use block height to query milestones, not id
vasild Feb 27, 2019
cb22138
feat(crypto): Handle previous block id wrt idFullSha256
vasild Feb 27, 2019
ecc9262
Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid
vasild Feb 27, 2019
a01409a
Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid
vasild Feb 28, 2019
9ed5b22
test(core-forger): adjust sampleBlock
vasild Feb 28, 2019
b5e93bf
test(core-p2p): adjust fixture and validation schemas
vasild Feb 28, 2019
6df24fc
test(core-debugger-cli): Adjust block fixture
vasild Feb 28, 2019
71a8730
Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid
vasild Feb 28, 2019
26743af
Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid
vasild Mar 1, 2019
8b480c5
feat(crypto): Strengthen the block id check
vasild Mar 1, 2019
2008688
Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid
vasild Mar 4, 2019
75d8952
Revert fixtures changes, new tests to be added for the new block id
vasild Mar 4, 2019
6bac1a8
fix(crypto): Accept old/partial hex block id
vasild Mar 4, 2019
4b08c95
feat(crypto): increase the height for activating full SHA256 block ids
vasild Mar 4, 2019
15556e3
Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid
vasild Mar 4, 2019
20af8c5
test(crypto): fix and extend blockId validation test
vasild Mar 4, 2019
c53015b
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 4, 2019
71753d4
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 6, 2019
70386da
test(core-forger): Don't use devnet config from unit tests
vasild Mar 6, 2019
dddcb6e
feat(crypto): Lower devnet block.idFullSha256 milestone
vasild Mar 6, 2019
84f3710
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 7, 2019
bb7b357
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 8, 2019
2466311
Try to tweak the fixture block
vasild Mar 8, 2019
fee99c3
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 8, 2019
db19ae1
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 11, 2019
613c639
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 11, 2019
5fdc05c
test(core-tester-cli): adjust block fixture
vasild Mar 11, 2019
0cd7177
test(core-forger): adjust block fixture
vasild Mar 11, 2019
ab2a493
test(crypto): adjust block fixtures
vasild Mar 11, 2019
5b278e4
misc(crypto): adjust height to switch to full sha256 block ids
vasild Mar 12, 2019
4f6edad
fix(crypto): Properly handle the first block with full sha256 id
vasild Mar 12, 2019
d58350e
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 12, 2019
595ca11
Merge branch 'develop' into blockid
spkjp Mar 13, 2019
ec1d5f1
Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
vasild Mar 13, 2019
a8b4085
misc(crypto): Lower devnet milestone for full sha256 block id
vasild Mar 13, 2019
f744941
misc(crypto): Introduce custom error class for prev block id mismatch
vasild Mar 13, 2019
306463e
chore(crypto): rename a variable for readability
vasild Mar 13, 2019
d91fdf0
chore(crypto): Rename schema keyword for clarity
vasild Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid 
* ArkEcosystem/core/2.3:
  refactor(crypto): de/serialization (#2175)
  • Loading branch information
@vasild
vasild committed Mar 1, 2019
commit 26743af83064d7f7b7c6c9d7c380e68ff1dbd2e6
5 changes: 0 additions & 5 deletions packages/crypto/src/validation/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ export const schemas = {
allOf: [{ minLength: 34, maxLength: 34 }, { $ref: "base58" }],
},

blockId: {
$id: "blockId",
$ref: "hex",
},

publicKey: {
$id: "publicKey",
allOf: [{ minLength: 66, maxLength: 66 }, { $ref: "hex" }, { transform: ["toLowerCase"] }],
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.