Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-snapshots-cli): require network parameter to be passed #2146

Closed
wants to merge 3 commits into from

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Require the network parameter to be passed in and rename the npm bin to avoid name collisions.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link

ghost commented Feb 24, 2019

@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 24, 2019 17:15
@codecov-io
Copy link

codecov-io commented Feb 24, 2019

Codecov Report

Merging #2146 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2146   +/-   ##
========================================
  Coverage    79.48%   79.48%           
========================================
  Files          330      330           
  Lines         7913     7913           
  Branches      1083     1107   +24     
========================================
  Hits          6290     6290           
  Misses        1590     1590           
  Partials        33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ec08f...2690a84. Read the comment docs.

@faustbrian faustbrian closed this Feb 25, 2019
@ghost ghost removed the Status: Needs Review label Feb 25, 2019
@faustbrian faustbrian deleted the cli/snapshots branch February 25, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants