Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Make it possible to disable a non-dev warning #2120

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

vasild
Copy link
Contributor

@vasild vasild commented Feb 19, 2019

A warning targeted for non-developers is just a noise with a flashing
light in the log for developers, add a possibility to silence it.

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

A warning targeted for non-developers is just a noise with a flashing
light in the log for developers, add a possibility to silence it.
@ghost
Copy link

ghost commented Feb 19, 2019

@air1one @faustbrian @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 19, 2019 13:37
@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #2120 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2120   +/-   ##
========================================
  Coverage    79.34%   79.34%           
========================================
  Files          329      329           
  Lines         7920     7920           
  Branches      1125     1141   +16     
========================================
  Hits          6284     6284           
  Misses        1603     1603           
  Partials        33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0871720...3bafa3a. Read the comment docs.

@faustbrian faustbrian changed the title chore(core): Make it possible to disable a non-dev warning refactor(core): Make it possible to disable a non-dev warning Feb 19, 2019
@faustbrian faustbrian merged commit 92d25e2 into develop Feb 19, 2019
@ghost ghost deleted the silence-non-dev-warning branch February 19, 2019 14:20
@ghost ghost removed the Status: Needs Review label Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants