Skip to content

Commit

Permalink
feat(core-transactions): unvote+vote transaction (#4044)
Browse files Browse the repository at this point in the history
  • Loading branch information
@rainydio
rainydio authored Sep 18, 2020
1 parent a917e08 commit 700b9cd
Show file tree
Hide file tree
Showing 3 changed files with 193 additions and 58 deletions.
180 changes: 156 additions & 24 deletions __tests__/unit/core-transactions/handlers/two/vote.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,12 @@ describe("VoteTransaction", () => {
let unvoteTransaction: Interfaces.ITransaction;
let secondSignatureUnvoteTransaction: Interfaces.ITransaction;
let multiSignatureUnvoteTransaction: Interfaces.ITransaction;
let delegateWallet: Wallets.Wallet;
let voteUnvoteTransaction: Interfaces.ITransaction;
let unvoteVoteTransaction: Interfaces.ITransaction;
let voteVoteTransaction: Interfaces.ITransaction;
let unvoteUnvoteTransaction: Interfaces.ITransaction;
let delegateWallet1: Wallets.Wallet;
let delegateWallet2: Wallets.Wallet;
let handler: TransactionHandler;

beforeEach(async () => {
Expand All @@ -93,61 +98,93 @@ describe("VoteTransaction", () => {
2,
);

delegateWallet = factoryBuilder
delegateWallet1 = factoryBuilder
.get("Wallet")
.withOptions({
passphrase: passphrases[8],
nonce: 0,
})
.make();
delegateWallet1.setAttribute("delegate", { username: "test1" });
walletRepository.index(delegateWallet1);

delegateWallet.setAttribute("delegate", { username: "test" });

walletRepository.index(delegateWallet);
delegateWallet2 = factoryBuilder
.get("Wallet")
.withOptions({
passphrase: passphrases[9],
nonce: 0,
})
.make();
delegateWallet2.setAttribute("delegate", { username: "test2" });
walletRepository.index(delegateWallet2);

voteTransaction = BuilderFactory.vote()
.votesAsset(["+" + delegateWallet.publicKey!])
.votesAsset(["+" + delegateWallet1.publicKey!])
.nonce("1")
.sign(passphrases[0])
.build();

secondSignatureVoteTransaction = BuilderFactory.vote()
.votesAsset(["+" + delegateWallet.publicKey!])
.votesAsset(["+" + delegateWallet1.publicKey!])
.nonce("1")
.sign(passphrases[1])
.secondSign(passphrases[2])
.build();

multiSignatureVoteTransaction = BuilderFactory.vote()
.senderPublicKey(multiSignatureWallet.publicKey!)
.votesAsset(["+" + delegateWallet.publicKey!])
.votesAsset(["+" + delegateWallet1.publicKey!])
.nonce("1")
.multiSign(passphrases[0], 0)
.multiSign(passphrases[1], 1)
.multiSign(passphrases[2], 2)
.build();

unvoteTransaction = BuilderFactory.vote()
.votesAsset(["-" + delegateWallet.publicKey!])
.votesAsset(["-" + delegateWallet1.publicKey!])
.nonce("1")
.sign(passphrases[0])
.build();

secondSignatureUnvoteTransaction = BuilderFactory.vote()
.votesAsset(["-" + delegateWallet.publicKey!])
.votesAsset(["-" + delegateWallet1.publicKey!])
.nonce("1")
.sign(passphrases[1])
.secondSign(passphrases[2])
.build();

multiSignatureUnvoteTransaction = BuilderFactory.vote()
.senderPublicKey(multiSignatureWallet.publicKey!)
.votesAsset(["-" + delegateWallet.publicKey!])
.votesAsset(["-" + delegateWallet1.publicKey!])
.nonce("1")
.multiSign(passphrases[0], 0)
.multiSign(passphrases[1], 1)
.multiSign(passphrases[2], 2)
.build();

voteUnvoteTransaction = BuilderFactory.vote()
.votesAsset(["+" + delegateWallet1.publicKey!, "-" + delegateWallet1.publicKey!])
.nonce("1")
.sign(passphrases[0])
.build();

unvoteVoteTransaction = BuilderFactory.vote()
.votesAsset(["-" + delegateWallet1.publicKey!, "+" + delegateWallet2.publicKey!])
.nonce("1")
.sign(passphrases[0])
.build();

voteVoteTransaction = BuilderFactory.vote()
.votesAsset(["+" + delegateWallet1.publicKey!, "+" + delegateWallet2.publicKey!])
.nonce("1")
.sign(passphrases[0])
.build();

unvoteUnvoteTransaction = BuilderFactory.vote()
.votesAsset(["-" + delegateWallet1.publicKey!, "-" + delegateWallet2.publicKey!])
.nonce("1")
.sign(passphrases[0])
.build();
});

describe("bootstrap", () => {
Expand All @@ -169,7 +206,7 @@ describe("VoteTransaction", () => {
transactionHistoryService.streamByCriteria.mockImplementationOnce(async function* () {
yield voteTransaction.data;
});
senderWallet.setAttribute("vote", delegateWallet.publicKey);
senderWallet.setAttribute("vote", delegateWallet1.publicKey);
await expect(handler.bootstrap()).rejects.toThrow(AlreadyVotedError);
});

Expand Down Expand Up @@ -258,34 +295,34 @@ describe("VoteTransaction", () => {
});

it("should not throw if the unvote is valid and the wallet has voted", async () => {
senderWallet.setAttribute("vote", delegateWallet.publicKey);
senderWallet.setAttribute("vote", delegateWallet1.publicKey);
await expect(handler.throwIfCannotBeApplied(unvoteTransaction, senderWallet)).toResolve();
});

it("should not throw - second sign unvote", async () => {
secondSignatureWallet.setAttribute("vote", delegateWallet.publicKey);
secondSignatureWallet.setAttribute("vote", delegateWallet1.publicKey);
await expect(
handler.throwIfCannotBeApplied(secondSignatureUnvoteTransaction, secondSignatureWallet),
).toResolve();
});

it("should not throw - multi sign unvote", async () => {
multiSignatureWallet.setAttribute("vote", delegateWallet.publicKey);
multiSignatureWallet.setAttribute("vote", delegateWallet1.publicKey);
await expect(
handler.throwIfCannotBeApplied(multiSignatureUnvoteTransaction, multiSignatureWallet),
).toResolve();
});

it("should throw if wallet has already voted", async () => {
senderWallet.setAttribute("vote", delegateWallet.publicKey);
senderWallet.setAttribute("vote", delegateWallet1.publicKey);
await expect(handler.throwIfCannotBeApplied(voteTransaction, senderWallet)).rejects.toThrow(
AlreadyVotedError,
);
});

it("should throw if vote for non delegate wallet", async () => {
delegateWallet.forgetAttribute("delegate");
walletRepository.index(delegateWallet);
delegateWallet1.forgetAttribute("delegate");
walletRepository.index(delegateWallet1);
await expect(handler.throwIfCannotBeApplied(voteTransaction, senderWallet)).rejects.toThrow(
VotedForNonDelegateError,
);
Expand All @@ -311,7 +348,7 @@ describe("VoteTransaction", () => {

it("should throw if wallet has insufficient funds for unvote", async () => {
senderWallet.balance = Utils.BigNumber.ZERO;
senderWallet.setAttribute("vote", delegateWallet.publicKey);
senderWallet.setAttribute("vote", delegateWallet1.publicKey);
await expect(handler.throwIfCannotBeApplied(unvoteTransaction, senderWallet)).rejects.toThrow(
InsufficientBalanceError,
);
Expand All @@ -332,6 +369,44 @@ describe("VoteTransaction", () => {
Exceptions.Runtime.AssertionException,
);
});

it("should not throw on vote+unvote transaction when wallet has not voted", async () => {
await handler.throwIfCannotBeApplied(voteUnvoteTransaction, senderWallet);
});

it("should throw on vote+unvote transaction when wallet has voted", async () => {
senderWallet.setAttribute("vote", delegateWallet1.publicKey);

await expect(handler.throwIfCannotBeApplied(voteUnvoteTransaction, senderWallet)).rejects.toThrow(
AlreadyVotedError,
);
});

it("should not throw on unvote+vote transaction when wallet has voted", async () => {
senderWallet.setAttribute("vote", delegateWallet1.publicKey);

await handler.throwIfCannotBeApplied(unvoteVoteTransaction, senderWallet);
});

it("should throw on unvote+vote transaction when wallet has not voted", async () => {
await expect(handler.throwIfCannotBeApplied(unvoteVoteTransaction, senderWallet)).rejects.toThrow(
NoVoteError,
);
});

it("should throw on vote+vote transaction when wallet has not voted", async () => {
await expect(handler.throwIfCannotBeApplied(voteVoteTransaction, senderWallet)).rejects.toThrow(
AlreadyVotedError,
);
});

it("should throw on unvote+unvote transaction when wallet has voted", async () => {
senderWallet.setAttribute("vote", delegateWallet1.publicKey);

await expect(handler.throwIfCannotBeApplied(unvoteUnvoteTransaction, senderWallet)).rejects.toThrow(
NoVoteError,
);
});
});

describe("throwIfCannotEnterPool", () => {
Expand All @@ -358,7 +433,7 @@ describe("VoteTransaction", () => {
});

it("should not be ok", async () => {
senderWallet.setAttribute("vote", delegateWallet.publicKey);
senderWallet.setAttribute("vote", delegateWallet1.publicKey);

expect(senderWallet.getAttribute("vote")).not.toBeUndefined();

Expand All @@ -370,7 +445,7 @@ describe("VoteTransaction", () => {

describe("unvote", () => {
it("should remove the vote from the wallet", async () => {
senderWallet.setAttribute("vote", delegateWallet.publicKey);
senderWallet.setAttribute("vote", delegateWallet1.publicKey);

expect(senderWallet.getAttribute("vote")).not.toBeUndefined();

Expand All @@ -379,6 +454,40 @@ describe("VoteTransaction", () => {
expect(senderWallet.hasAttribute("vote")).toBeFalse();
});
});

describe("vote+unvote", () => {
it("should apply when wallet has not voted", async () => {
await handler.apply(voteUnvoteTransaction);

expect(senderWallet.hasAttribute("vote")).toBeFalse();
});

it("should throw when wallet has voted", async () => {
senderWallet.setAttribute("vote", delegateWallet1.publicKey);

await expect(handler.apply(voteUnvoteTransaction)).rejects.toThrow(AlreadyVotedError);
});
});

describe("unvote+vote", () => {
it("should apply when wallet has voted", async () => {
senderWallet.setAttribute("vote", delegateWallet1.publicKey);

await handler.apply(unvoteVoteTransaction);

expect(senderWallet.getAttribute("vote")).toEqual(delegateWallet2.publicKey);
});

it("should throw when wallet has not voted", async () => {
await expect(handler.apply(unvoteUnvoteTransaction)).rejects.toThrow(NoVoteError);
});

it("should throw when wallet has voted for different delegate", async () => {
senderWallet.setAttribute("vote", delegateWallet2.publicKey);

await expect(handler.apply(unvoteUnvoteTransaction)).rejects.toThrow(UnvoteMismatchError);
});
});
});

describe("applyForSender", () => {
Expand All @@ -402,7 +511,7 @@ describe("VoteTransaction", () => {
describe("revert", () => {
describe("vote", () => {
it("should remove the vote from the wallet", async () => {
senderWallet.setAttribute("vote", delegateWallet.publicKey);
senderWallet.setAttribute("vote", delegateWallet1.publicKey);
senderWallet.nonce = Utils.BigNumber.make(1);

expect(senderWallet.getAttribute("vote")).not.toBeUndefined();
Expand All @@ -423,7 +532,28 @@ describe("VoteTransaction", () => {
await handler.revert(unvoteTransaction);

expect(senderWallet.nonce.isZero()).toBeTrue();
expect(senderWallet.getAttribute("vote")).toBe(delegateWallet.publicKey);
expect(senderWallet.getAttribute("vote")).toBe(delegateWallet1.publicKey);
});
});

describe("vote+unvote", () => {
it("should revert when wallet has no vote", async () => {
senderWallet.nonce = Utils.BigNumber.make(1);

await handler.revert(voteUnvoteTransaction);

expect(senderWallet.hasAttribute("vote")).toBeFalse();
});
});

describe("unvote+vote", () => {
it("should revert when wallet has no vote", async () => {
senderWallet.setAttribute("vote", delegateWallet2.publicKey);
senderWallet.nonce = Utils.BigNumber.make(1);

await handler.revert(unvoteVoteTransaction);

expect(senderWallet.getAttribute("vote")).toEqual(delegateWallet1.publicKey);
});
});
});
Expand All @@ -444,7 +574,9 @@ describe("VoteTransaction", () => {

senderWallet.nonce = Utils.BigNumber.ONE;

await expect(handler.revertForSender(voteTransaction)).rejects.toThrow(Exceptions.Runtime.AssertionException);
await expect(handler.revertForSender(voteTransaction)).rejects.toThrow(
Exceptions.Runtime.AssertionException,
);
});
});
});
Loading

0 comments on commit 700b9cd

Please sign in to comment.