Skip to content

feat: better serialization #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: better serialization #195

wants to merge 1 commit into from

Conversation

Ark2000
Copy link
Owner

@Ark2000 Ark2000 commented Sep 11, 2024

re pull request
see #189

@Ark2000 Ark2000 mentioned this pull request Sep 11, 2024
Closed
@Ark2000 Ark2000 requested a review from worron September 11, 2024 03:39
@Ark2000 Ark2000 added Feature✨ New feature or request Improvement✒ labels Sep 11, 2024
worron
worron approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@worron worron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good for me. Possibility to edit config in Godot editor feels great.

The only downside is that user settings will be reset to defaults with new file format. I suggest bump version after merging this and highlight this minor inconvenience in change log.

pewcworrell

This comment was marked as off-topic.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worron worron worron approved these changes

+1 more reviewer

@pewcworrell pewcworrell pewcworrell requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Feature✨ New feature or request Improvement✒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ark2000 @worron @pewcworrell