Skip to content

chore: project setup and tooling cleanup#26

Merged
Ark0N merged 12 commits intomasterfrom
cleanup/add-project-setup
Feb 27, 2026
Merged

chore: project setup and tooling cleanup#26
Ark0N merged 12 commits intomasterfrom
cleanup/add-project-setup

Conversation

@noahwaldner
Copy link
Collaborator

@noahwaldner noahwaldner commented Feb 27, 2026

Summary

  • Add project tooling: ESLint config, Prettier, .editorconfig, .nvmrc, .gitignore, CI workflow
  • Add scripts/build.mjs build script
  • Move remotion assets under tools/remotion/
  • Remove CONTRIBUTING.md
  • Fix npm run dev in CLAUDE.md — it now correctly starts the web server, not just prints CLI help

Test plan

  • npm run dev starts the web server at http://localhost:3000
  • npm run typecheck passes
  • npm run lint passes

🤖 Generated with Claude Code

noahwaldner and others added 11 commits February 27, 2026 10:54
Merged changeset scripts/devDeps from master with ESLint/Prettier
tooling added on this branch.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@noahwaldner noahwaldner requested a review from Ark0N February 27, 2026 10:51
@Ark0N
Copy link
Owner

Ark0N commented Feb 27, 2026

PR Review

Size: +4,698 / -4,404 across 61 files — ~95% is Prettier reformatting. ~12 substantive code changes buried in the noise, all safe.


Behavioral Changes

1. npm run dev now starts the web server — Previously showed CLI help, now runs tsx src/index.ts web. CLAUDE.md updated to match, but the existing CRITICAL gotcha warning about this was softened to a plain "Note" — should either remove the gotcha entirely or keep the emphasis.

2. Remotion moved to devDependencies@remotion/cli, @remotion/transitions, remotion moved from dependencies to devDependencies. Safe, remotion is tooling-only.

3. npm workspaces added"workspaces": ["packages/*"] enables workspace support for packages/xterm-zerolag-input/.

4. Remotion files moved from remotion/ to tools/remotion/ — pure rename.

5. CONTRIBUTING.md removed.

Real Code Changes (Buried in Formatting)

Change Files Assessment
letconst (never reassigned) session-lifecycle-log.ts, subagent-watcher.ts ✅ Correct
Spread operator assertion parens: ...(x as T) respawn-controller.ts ✅ Prevents potential misparse
Generator methods modernized: *keys() stale-expiration-map.ts ✅ Semantically identical, cleaner
interface Foo extends Bar {}type Foo = Bar ai-idle-checker.ts, ai-plan-checker.ts ✅ Equivalent
Unnecessary regex escapes removed in [...] 5 files ✅ Identical behavior
Arithmetic parenthesization server.ts, tmux-manager.ts ✅ Identical, just clearer
eslint-disable comments for \x1b regexes Multiple ✅ Required by new ESLint config

None touch critical paths (respawn, session management, state persistence, SSE).


Issues to Address

1. .nvmrc / CI Node version mismatch.nvmrc says 22, CI uses node-version: 20. Pick one. Will confuse contributors who run nvm use.

2. app.js excluded from both ESLint and Prettier — The 15K-line frontend file has zero automated quality checks while everything else does. Understandable for this PR's scope, but worth noting as a permanent gap.

3. 80-char print width is aggressive — The codebase was written with wider lines. This is the source of most of the diff noise and will affect all future diffs.


Verdict

Safe to merge — no logic regressions. The formatting churn is large but clean.

Copy link
Owner

@Ark0N Ark0N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall — the tooling additions (ESLint, Prettier, CI, build script extraction) are solid and the ~12 real code changes are all improvements. No logic regressions found.

Two items to fix before merge:

  1. .nvmrc says 22, CI uses 20 — pick one to avoid confusing nvm use
  2. CLAUDE.md gotcha about npm run dev — now that it starts the web server, either remove the gotcha or update it to reflect the new behavior instead of softening the warning

Otherwise LGTM.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Ark0N Ark0N merged commit 480584d into master Feb 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants