Implement two-way GitHub synchronization for action items

[ArjinAlbay]

• Updated markAsRead function to handle GitHub API synchronization
• When marking items as read, now closes issues/PRs on GitHub
• Ensures consistency between local app state and GitHub
• Simplified QuickActionsMenu by delegating sync logic to store
• Added proper error handling for GitHub API calls

Resolves issue HappyHackingSpace#113

Summary by CodeRabbit

Release Notes

• New Features
  • Closing action items now directly closes the associated GitHub issue or pull request, ensuring changes sync with your repository
  • Action items are now categorized by type (assigned, mentions, stale) for improved management and clarity

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
githubmon	Ready	Preview	Comment	Nov 17, 2025 7:05pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The refactoring consolidates action-item closing logic into the actionItems store. The QuickActionsMenu API changed from callback-based to type-based (itemType prop). The markAsRead function now handles GitHub API calls asynchronously, eliminating direct API dependencies from the component layer.

Changes

Cohort / File(s)	Summary
UI component prop signature update src/app/action-required/page.tsx	Removed markAsRead destructuring and handleItemClosed function; updated QuickActionsMenu prop from onItemClosed callback to itemType union type ("assigned" | "mentions" | "stale").
QuickActionsMenu refactoring src/components/action-required/QuickActionsMenu.tsx	Removed onItemClosed prop and GitHub API logic; introduced itemType prop; replaced GitHub API calls with store-based markAsRead invocation; removed parseRepoFromUrl helper and token/auth handling.
Store async implementation src/stores/actionItems.ts	Converted markAsRead from synchronous void to asynchronous Promise-returning function; added token validation, URL parsing, GitHub API calls (issue/PR closure), state mutation on success, and comprehensive error handling with early returns.

Sequence Diagram

sequenceDiagram
    participant User
    participant QuickActionsMenu
    participant ActionItemsStore
    participant GitHubAPI
    participant AuthStore

    User->>QuickActionsMenu: Clicks close button
    QuickActionsMenu->>ActionItemsStore: markAsRead(itemType, id)
    ActionItemsStore->>AuthStore: Retrieve user token
    ActionItemsStore->>ActionItemsStore: Locate item by id
    ActionItemsStore->>ActionItemsStore: Parse repo/issue from URL
    
    rect rgba(200, 220, 255, 0.3)
        Note over ActionItemsStore,GitHubAPI: Async GitHub API Call
        ActionItemsStore->>GitHubAPI: Close issue/PR
    end
    
    alt Success
        GitHubAPI-->>ActionItemsStore: Success response
        ActionItemsStore->>ActionItemsStore: Remove item from state
        ActionItemsStore-->>QuickActionsMenu: Promise resolved
        QuickActionsMenu-->>User: Dialog hidden, state updated
    else Error
        GitHubAPI-->>ActionItemsStore: Error
        ActionItemsStore->>ActionItemsStore: Log error
        ActionItemsStore-->>QuickActionsMenu: Promise rejected
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• QuickActionsMenu refactoring: Verify removal of GitHub API logic is complete and that store-based markAsRead is correctly invoked; ensure itemType prop is properly utilized.
• Async conversion in actionItems.ts: Validate token retrieval, URL parsing logic, and error handling paths (especially edge cases: missing token, item not found, unparseable URL).
• Cross-file prop changes: Confirm QuickActionsMenu prop signature changes are consistently propagated through all call sites in page.tsx.
• Promise handling: Ensure markAsRead async behavior is properly awaited or handled at call sites.

Possibly related PRs

• Add one-click quick actions for task management (#110) #9: Introduced QuickActionsMenu with onItemClosed callback and GitHub API client integration; this PR refactors that design to move GitHub close logic into the actionItems store with async markAsRead and itemType-based props.

Poem

🐰 The store now holds the keys so bright,
No more callbacks tangled tight,
Async flows with types defined,
GitHub logic, neatly aligned—
Close buttons, simple and light! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch claude/resolve-github-issues-01R6Dp8FWwHhQCGTBay9eG1F

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05527d4 and ebd96ec.

📒 Files selected for processing (3)

• src/app/action-required/page.tsx (1 hunks)
• src/components/action-required/QuickActionsMenu.tsx (4 hunks)
• src/stores/actionItems.ts (3 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}