Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): ensure auth works behind a proxy #5374

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Nov 15, 2024

  • ensure fetch requests to auth-related routes include the base path if configured
  • ensure login redirect url excludes base url if configured
  • ensure oauth2 works behind proxy

resolves #5368
resolves #5376
resolves #5374

@axiomofjoy axiomofjoy changed the title fix(auth): ensure correct redirect url when phoenix is deployed behind a proxy fix(auth): ensure auth works behind a proxy Nov 15, 2024
Comment on lines -111 to +113
"dev:server": "source .env && tox r -e phoenix_main -- --dev serve",
"dev:server": "source .env && phoenix --dev serve",
"dev:server:test": "node ./tests/utils/testServer.mjs",
"dev:server:init": "tox r -e phoenix_main -- --dev serve --with-trace-fixtures=llama_index_rag --with-projects=demo_llama_index --force-fixture-ingestion",
"dev:server:init": "phoenix --dev serve --with-trace-fixtures=llama_index_rag --with-projects=demo_llama_index --force-fixture-ingestion",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like tox does not pick up env vars

@axiomofjoy axiomofjoy marked this pull request as ready for review November 15, 2024 09:30
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: 📘 Todo
1 participant