Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): rudimentary graphql support for messages input #4907

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

mikeldking
Copy link
Contributor

resolves 4893

Switches the input of the chat completion message to be a list of messages with roles.

subscription {
  chatCompletion(input: {
    messages: [{ role: USER, content: "hello"}]
  })
}
Screen.Recording.2024-10-07.at.5.37.04.PM.mov

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 7, 2024
Copy link
Contributor

@cephalization cephalization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out at me in the code, looks good.

No errors during runtime in browser console or terminal 👍🏽

>
<Item key="system">System</Item>
<Item key="user">User</Item>
<Item key="assistant">Assistant</Item>
<Item key="ai">ai</Item>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization? Or do we prefer it stylized as lowercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@mikeldking mikeldking merged commit 5e9a83f into playground Oct 8, 2024
17 checks passed
@mikeldking mikeldking deleted the mikeldking/chat-completion branch October 8, 2024 01:33
mikeldking added a commit that referenced this pull request Oct 9, 2024
* feat(playground): Chat message with role

* feat(playground): pass in messages and roles

* Update app/src/pages/playground/MessageRolePicker.tsx
mikeldking added a commit that referenced this pull request Oct 11, 2024
* feat(playground): Chat message with role

* feat(playground): pass in messages and roles

* Update app/src/pages/playground/MessageRolePicker.tsx
mikeldking added a commit that referenced this pull request Oct 11, 2024
* feat(playground): Chat message with role

* feat(playground): pass in messages and roles

* Update app/src/pages/playground/MessageRolePicker.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants