fix(app): resolve project routes that use project names#12924
Open
pandego wants to merge 1 commit intoArize-ai:mainfrom
Open
fix(app): resolve project routes that use project names#12924pandego wants to merge 1 commit intoArize-ai:mainfrom
pandego wants to merge 1 commit intoArize-ai:mainfrom
Conversation
dosubot
Bot
added
the
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12908
This keeps
/projects/<name>/...links working by resolving project names to the canonical Relay global ID before the project loader queriesnode(id: ...).It also hardens
is_composite_global_id()so invalid base64 strings returnFalseinstead of bubbling a decode error through GraphQL.Validation:
pnpm --dir app exec oxlint src/pages/project/projectLoader.ts __tests__/projectLoader.test.tspnpm --dir app exec tsc --noEmitpnpm --dir app exec vitest run __tests__/projectLoader.test.tsuv run ruff check src/phoenix/server/api/types/node.py tests/unit/server/api/types/test_node.pyuv run pytest tests/unit/server/api/types/test_node.py