Skip to content

Conversation

@cephalization
Copy link
Contributor

@cephalization cephalization commented Oct 26, 2025

apply.and.create.labels.mov

Note

Integrates dataset label creation directly into the dataset label assignment popover and removes ComboBox portal/container props across the app, adding a shared label-mutations hook.

  • Dataset Labels:
    • Integrated Create + Apply Flow: DatasetLabelConfigButton now toggles between applying existing labels and creating new ones within the same popover (apply/create modes), removing separate modals.
    • New Hook: Adds useDatasetLabelMutations to centralize label creation, error handling, and Relay connection updates; updates NewDatasetLabelDialog to use it.
    • UI tweaks: Fixed popover widths, list height constraints, back button, and conditional search; minor submenu popover sizing in DatasetActionMenu.
  • ComboBox:
    • Removes container/portal usage; Popover renders without UNSTABLE_portalContainer. Sets default width to "100%".
    • Cleans up all consumers to drop container prop (ModelComboBox, ModelConfigButton fields, PromptComboBox, SavePromptForm).
  • GraphQL/Relay:
    • Adds generated mutation useDatasetLabelMutationsAddLabelMutation and uses @prependNode to update DatasetLabelEdge connections.

Written by Cursor Bugbot for commit 17c8597. This will update automatically on new commits. Configure here.

@cephalization cephalization requested a review from a team as a code owner October 26, 2025 14:42
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Oct 26, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 26, 2025
cursor[bot]

This comment was marked as outdated.

Base automatically changed from donny/dataset-label-graphql-set to main October 26, 2025 16:32
@axiomofjoy axiomofjoy requested a review from a team as a code owner October 26, 2025 16:32
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 26, 2025
@cephalization cephalization force-pushed the cephalization/dataset-labels-stacking branch from e16d5ae to 802beff Compare October 27, 2025 01:27
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 27, 2025
cursor[bot]

This comment was marked as outdated.

@github-project-automation github-project-automation bot moved this from 📘 Todo to 👍 Approved in phoenix Oct 27, 2025
inset: 0;
background: rgba(0 0 0 / 0.5);
z-index: 1000;
z-index: var(--ac-global-z-index-modal-overlay);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks modals that have dropdowns/popovers inside of them, like the playground model settings dialog

const [showNewLabelDialog, setShowNewLabelDialog] = useState<boolean>(false);

return (
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the fragment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

cursor[bot]

This comment was marked as outdated.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 28, 2025
cursor[bot]

This comment was marked as outdated.

@cephalization cephalization changed the title fix: Ensure correct model/popover stacking context when adding dataset labels feat: Merge dataset label application with new label creation Oct 28, 2025
@cephalization cephalization merged commit c6cb7da into main Oct 29, 2025
20 of 21 checks passed
@cephalization cephalization deleted the cephalization/dataset-labels-stacking branch October 29, 2025 13:27
@github-project-automation github-project-automation bot moved this from 👍 Approved to ✅ Done in phoenix Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants