-
Couldn't load subscription status.
- Fork 609
feat: Merge dataset label application with new label creation #10014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e16d5ae to
802beff
Compare
app/src/components/overlay/Modal.tsx
Outdated
| inset: 0; | ||
| background: rgba(0 0 0 / 0.5); | ||
| z-index: 1000; | ||
| z-index: var(--ac-global-z-index-modal-overlay); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks modals that have dropdowns/popovers inside of them, like the playground model settings dialog
| const [showNewLabelDialog, setShowNewLabelDialog] = useState<boolean>(false); | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the fragment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
apply.and.create.labels.mov
Note
Integrates dataset label creation directly into the dataset label assignment popover and removes ComboBox portal/container props across the app, adding a shared label-mutations hook.
DatasetLabelConfigButtonnow toggles between applying existing labels and creating new ones within the same popover (apply/createmodes), removing separate modals.useDatasetLabelMutationsto centralize label creation, error handling, and Relay connection updates; updatesNewDatasetLabelDialogto use it.DatasetActionMenu.container/portal usage;Popoverrenders withoutUNSTABLE_portalContainer. Sets defaultwidthto"100%".containerprop (ModelComboBox,ModelConfigButtonfields,PromptComboBox,SavePromptForm).useDatasetLabelMutationsAddLabelMutationand uses@prependNodeto updateDatasetLabelEdgeconnections.Written by Cursor Bugbot for commit 17c8597. This will update automatically on new commits. Configure here.