Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mistral): add agent support #1043

Merged
merged 13 commits into from
Oct 2, 2024
Merged

feat(mistral): add agent support #1043

merged 13 commits into from
Oct 2, 2024

Conversation

harrisonchu
Copy link
Contributor

No description provided.

@harrisonchu harrisonchu requested a review from a team as a code owner September 18, 2024 02:26
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 18, 2024

tracer_provider = trace_sdk.TracerProvider()
tracer_provider.add_span_processor(SimpleSpanProcessor(ConsoleSpanExporter()))
trace_api.set_tracer_provider(tracer_provider)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for our examples we should be setting the tracer provider directly in the instrument function, I think it's just a bit better of a pattern

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 18, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 18, 2024
@harrisonchu harrisonchu changed the title feat(mistral) add agent support feat(mistral): add agent support Sep 18, 2024
@harrisonchu harrisonchu merged commit d1d6b2f into main Oct 2, 2024
3 of 4 checks passed
@harrisonchu harrisonchu deleted the mistral-agent branch October 2, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants