Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missed ref_doc_id in retrieval #1025

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mystdeim
Copy link

DOCUMENT_ID is actually node.node_id now.
It's difficult to track documents which are found by retrieval stage.
I suggest adding ref_doc_id in the attributes.

@mystdeim mystdeim requested a review from a team as a code owner September 10, 2024 20:47
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 10, 2024
Copy link

vercel bot commented Sep 10, 2024

@mystdeim is attempting to deploy a commit to the Arize Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mystdeim
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 10, 2024
@RogerHYang RogerHYang self-requested a review September 11, 2024 03:34
@RogerHYang
Copy link
Contributor

OK I now understand the issue. Thank you for bringing this to our attention.

Let me discuss it with the team first, and follow up with you afterwards.

@RogerHYang RogerHYang self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: 📘 Todo
Development

Successfully merging this pull request may close these issues.

2 participants