fix: fix failed to parse userdata of the first tag #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shabbywu
force-pushed
the
fix/tag-userdata-parse-error
branch
from
4b66d1b to
32247fb
Compare
AristurtleDev
approved these changes
Jul 8, 2025
|
Sorry for the delay @shabbywu, looked over the PR and looks good. Thanks for the fix. |
AristurtleDev
added a commit
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The UserData of first tag will be dropped if the doc have multiple tags.
As the doc show, USER DATA CHUNK is following the TAG Chunk, and all user data of tags are order by serial follow the tags.
Thereforce, when the programe first into the USER DATA CHUNK, the var
currentUserDatais actually referring the one of last tag.So we should fix it up to the right one.
Related Issue Ticket Numbers
#30